Completed my MP1 #12
Open
Completed my MP1 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elepert
reviewed
Oct 5, 2017
| >>> get_complement('T') | ||
| 'A' | ||
| >>> get_complement('G') | ||
| 'C' | ||
| """ | ||
| # TODO: implement this |
There was a problem hiding this comment.
Stylistic comment: Remove TODOs when you've implemented the code
Elepert
reviewed
Oct 5, 2017
| elif nucleotide == 'C': | ||
| return 'G' | ||
| else: | ||
| return 'C' |
There was a problem hiding this comment.
Stylistic comment: Instead of using a bunch of if and else statements and now that you've learned what dictionaries are, you could do something like this as well :
nucleotide_complements' = {'A':'T', 'T':'C', 'C':'G', 'G':'C'}
return nucleotide_complements[nucleotide]
Elepert
reviewed
Oct 5, 2017
| orf_list = orf_list + find_all_ORFs_oneframe(dna[1:]) | ||
| #second offset frame | ||
| orf_list = orf_list + find_all_ORFs_oneframe(dna[2:]) | ||
| return orf_list |
There was a problem hiding this comment.
If frames were larger than 3 codons long, you would have to copy the same line over and over, so putting it in a loop is a good choice.
Elepert
reviewed
Oct 5, 2017
| if len(orf) > longest_length: | ||
| longest_orf = orf | ||
| longest_length = len(orf) | ||
| return longest_orf |
There was a problem hiding this comment.
Technically longest_org = orf is redundant
|
I made a few stylistic suggestions for future reference. Keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.