Harrison Young Recursive Art #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fear the all-mighty gummy bear!!!
Intro to circuit design
My Reflection
SeunginLyu
reviewed
Oct 12, 2017
| @@ -2,6 +2,33 @@ | |||
|
|
|||
| import random | |||
| from PIL import Image | |||
| import math | |||
| pi = 3.14 | |||
There was a problem hiding this comment.
It's a stylistic convention to use all caps for constants. PI=3.14
| @@ -2,6 +2,33 @@ | |||
|
|
|||
| import random | |||
| from PIL import Image | |||
| import math | |||
| pi = 3.14 | |||
| def prod(a,b): #Returns the product of two values | |||
|
|
||
|
|
||
|
|
||
| # prod = ['prod',build_random_function(depth-1, depth-1),build_random_function(depth-1, depth-1)] |
There was a problem hiding this comment.
please remove comments for final code submission.
| # return "Error" | ||
| #TODO: implement this | ||
| #print (f) | ||
| e = evaluate_random_function #dummy function to make the code take up less room |
There was a problem hiding this comment.
i think it's actually more readable to use the full function name in this case.
| """ | ||
|
|
||
| difference = val-input_interval_start | ||
| difference = difference/ (input_interval_end - input_interval_start) |
There was a problem hiding this comment.
simple syntax : difference += input_interval_end - input_interval_start)
| red_function = build_random_function(9, 15) | ||
| green_function = build_random_function(9, 15) | ||
| blue_function = build_random_function(9, 15) | ||
| x = random.uniform(0, 1) |
There was a problem hiding this comment.
what is this line of code doing? Perhaps add an inline comment explaining why you added this line of code.
| @@ -43,7 +110,47 @@ def evaluate_random_function(f, x, y): | |||
| >>> evaluate_random_function(["y"],0.1,0.02) | |||
| 0.02 | |||
There was a problem hiding this comment.
I recommend that you add more unit tests of your own in future projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning in my project.