Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed computational art #6

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vivienyuwenchen
Copy link

No description provided.

Copy link

@SeunginLyu SeunginLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work! Your code is both concise and efficient. The only thing I would suggest to you is to add more inline comments where things can be a little confusing to a potential code reviewer.

func[1] = build_random_function(depth - 1, depth - 1)
func[2] = build_random_function(depth - 1, depth - 1)

return func

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely written readable code. 👍 The way you wrote this code makes it really clear what the function is doing.

@@ -164,8 +248,8 @@ def generate_art(filename, x_size=350, y_size=350):
# Create some computational art!
# TODO: Un-comment the generate_art function call after you

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these placeholders for your final code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants