Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Computational Art #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

iblancett
Copy link

No description provided.

Copy link

@SeunginLyu SeunginLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good overall! You went beyond the minimum requirement and generated a bunch of cool images. Your code is well-documented and is easy to follow. Nicely done! The only suggestion for you is to write more unit tests!



def build_random_function(min_depth, max_depth):
def build_random_function(min_depth, max_depth, movie):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extension! 👍

functions = ['prod', 'avg', 'acos_pi', 'asin_pi', 'cos_pi', 'sin_pi', 'cubed'] # possible operations

if movie:
variables = [['x'],['y'],['t']] # three variables when making a movie

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that you are explaining this in a inline comment



def evaluate_random_function(f, x, y):

def evaluate_random_function(f, x, y, t):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend that you add more unit tests of your own to test functions like this in future projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants