perf_tests: make column generic #2590
Open
+125
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a concept of a "column" in the perf test output, which given a result is a rest metric which can be output as a result of the test (as an actual column in stdout and md views, or as a property in the json writer). This means that all 3 writers will keep a consistent view of the available metrics (cycles was missing from md output before this change), and it also enables things like adjusting the columns shown in the future.
|
This solves missing cycles and somehow reduces duplication "in principle", though the duplication was mostly limited to horizontal duplication on a single line (but still error prone). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a concept of a "column" in the perf test output, which given a result is a rest metric which can be output as a result of the test (as an actual column in stdout and md views, or as a property in the json writer).
This means that all 3 writers will keep a consistent view of the available metrics (cycles was missing from md output before this change), and it also enables things like adjusting the columns shown in the future.