-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(managerclient): adds new task type - 1_1_restore #4219
base: master
Are you sure you want to change the base?
Conversation
This adds a new task type for fast vnode restore. Fixes: #4200
I really need to fix #4121.......... |
Also, just another idea in terms of #4200. What do you think @karol-kokoszka @VAveryanov8? |
Let's leave the discussion if we introduce new CLI to the Wednesday planning. It can be quickly changed. |
Let's name it "1-1-restore" for now. |
c2e40f6
to
39aa5f8
Compare
@karol-kokoszka @VAveryanov8 Just a general comment before merging - do we want to gradually merge the 121 restore changes to the master or to the feature branch? I would say that we should be merging things to master as it's annoying to keep on rebasing the feature branch. It's also annoying that merging to feature branch does not close fixed issues. |
It make sense to work on it with the feature branch. |
This adds a new task type for 1-1 vnode restore.
As managerclient is a separate go module, changes into it should be merged first.
Fixes: #4200
Please make sure that: