Restore improvement: unpin agent CPU #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it possible to specify multiple CPUs in 'scylla-manager-agent.yaml' config to which agent will be pinned. The 'cpu' field in config now allows for both single int and array of ints values. The default behavior remains the same.
Except for the extraction, this commit also increases log level (from DEBUG to INFO) of message about missing cpuset file. It also makes this function return an error, which is going to be useful when this function is going to be used inside the cpu pinning agent endpoints.
Michal-Leszczynski
force-pushed
the
ml/restore-cpu
branch
from
9793daa to
90b4bac
Compare
|
@karol-kokoszka This PR is ready for review! |
karol-kokoszka
approved these changes
Oct 21, 2024
This commit implement 3 cpu pinning endpoints allowing to query (GET), pin (POST) and unpin (DELETE) agent cpus.
This commit adds UnpinAgentCPU field to Target. It optionally allows to unpin agent from CPUs for the time of the restore. Fixes #3951
This should be done just because of safety. It prevents rare edge cases like: - restore runs with --allow-compaction=false - restore is paused - restore is modified with --allow-compaction=true - restore is resumed
This commit allows user to control whether agent should be pinned to CPUs during restore.
…th cpu pinning This way this test also checks cpu pinning before and after backup. It also checks cpu pinning before, in the middle, when paused, when resumed, and after restore.
Michal-Leszczynski
force-pushed
the
ml/restore-cpu
branch
from
90b4bac to
ff3aed9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new flag
--unpin-agent-cputo restore task (defaultfalse).It allows to unpinn agent from CPUs during restore (and re-pin it afterwards).
Moreover, for improved granularity, this PR also extends the
cpufield ofscylla-manager-agent.yamlconfig, so that user can specify a list of cpusinstead of just a single one. This allows for greater, but manual, control
over agent cpu pinning.
Fixes #3951