Extend rclone API with bandwidth limit/transfers on upload/download #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load APIs This is a groundwork needed for #3947 and #3948. Initially, the idea was to use dedicated endpoints to set the bandwidth_rate and transfers count used by all following rclone API calls (4c14076). This does approach does not work well with agent restarts, as the changes made by dedicated endpoints are not preserved after the restart. In order to change that, we add bandwidth_rate and transfers to rclone API calls responsible for uploading/downloading files. This way, each call to rclone API will validate that rclone server uses required amount of transfers (or set the amount if needed).
|
@karol-kokoszka This is the API changing PR for #4054, so it needs to be merged first so that I can set the commit hash from master branch in go.mod. |
karol-kokoszka
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a ground work required for #4054 required because it needs to extend rclone API.