Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure xfs-disk-setup lands on the same nodes as local-csi-driver #33

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Make sure xfs-disk-setup lands on the same nodes as local-csi-driver #33

merged 1 commit into from
Dec 4, 2023

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Dec 4, 2023

xfs-disk-setup and local-csi-driver are deployed together and must always land on the same set of nodes. This means their tolerations need to match as well or some could avoid some "dedicated" or otherwise tainted node and the other one would break.

Resolves #32

@tnozicka tnozicka added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 4, 2023
@scylla-operator-bot scylla-operator-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2023
@tnozicka tnozicka added this to the v0.3 milestone Dec 4, 2023
@tnozicka tnozicka mentioned this pull request Dec 4, 2023
Merged
@tnozicka tnozicka requested a review from zimnx December 4, 2023 14:59
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx zimnx removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 4, 2023
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 4, 2023
@zimnx zimnx added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 4, 2023
@zimnx zimnx enabled auto-merge December 4, 2023 15:05
@zimnx zimnx merged commit efe8b40 into scylladb:master Dec 4, 2023
27 of 33 checks passed
@tnozicka tnozicka deleted the tolerations branch December 4, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.

xfs-disk-setup and local-csi-driver got deployed to diferent nodes and failed to rollout
2 participants
@tnozicka @zimnx