Recalculate maxQueueSize based on shards count #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently maxQueueSize is 256 by default. Problem is that some hosts can have 1 shard, others can have 256 shards. While having cap of 256 pending requests for 1 shard host is ok. For host of 256 shards it is way to low. This commit scales maxQueueSize by number of shards, which allow default value works for hosts of any size.
dkropachev
force-pushed
the
dk/recalculate-max-queue-size-from-shardcount
branch
from
600ad77 to
1589ccc
Compare
Bouncheck
requested changes
Jul 9, 2025
There was a problem hiding this comment.
Hard objections:
setMaxQueueSize should also have the documentation updated.
Soft objections:
While the queue is global (per host I think), the description makes you think that the limits are per shard. This is not the case in the sense that one shard may use up the whole limit.
Regarding the name maybe maxQueueSizeFactor would be more descriptive now?
Different nodes will end up having different queue sizes if the number of shards is different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
maxQueueSizeis256by default.Problem is that some hosts can have 1 shard, others can have
256shards.While having cap of
256pending requests for1shard host is ok, for bigger host of256shards it is way to low.This commit scales
maxQueueSizeby number of shards, which allow default value works for hosts of any size.Fix: #577