Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set test files into order #399

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

sylwiaszunejko
Copy link
Collaborator

  1. Remove cassandra, scylla, all tags, leave only unit and integration tags in those files.
  2. Drop !scylla files.
  3. Change tags in worksflow running integration test in CI.

Fixes: #397

@sylwiaszunejko sylwiaszunejko self-assigned this Feb 20, 2025
@dkropachev
Copy link
Collaborator

@sylwiaszunejko , there are some tests in unit suit that need server running, could you please check them out and either move them to a separate integration file or fix them to not require the server

@sylwiaszunejko
Copy link
Collaborator Author

sylwiaszunejko commented Feb 20, 2025

@sylwiaszunejko , there are some tests in unit suit that need server running, could you please check them out and either move them to a separate integration file or fix them to not require the server

@dkropachev what tests do you mean? Shouldn't some tests fail if this is the case?

@dkropachev
Copy link
Collaborator

@sylwiaszunejko , there are some tests in unit suit that need server running, could you please check them out and either move them to a separate integration file or fix them to not require the server

@dkropachev what tests do you mean? Shouldn't some tests fail if this is the case?

I saw them failing on the pipeline, now it is all good.

@dkropachev dkropachev marked this pull request as ready for review February 20, 2025 12:43
dkropachev
dkropachev previously approved these changes Feb 20, 2025
@dkropachev
Copy link
Collaborator

@sylwiaszunejko , feel free to merge it

@sylwiaszunejko
Copy link
Collaborator Author

Not sure what to do with these tags:

* `tablet` https://github.com/scylladb/gocql/blob/master/tablet_integration_test.go

* `gofuzz` https://github.com/scylladb/gocql/blob/master/fuzz.go

* `ccm` https://github.com/scylladb/gocql/blob/master/control_ccm_test.go, https://github.com/scylladb/gocql/blob/master/events_ccm_test.go

* `genhostinfo` https://github.com/scylladb/gocql/blob/master/host_source_gen.go

* `appengine`, `s390x` https://github.com/scylladb/gocql/blob/master/internal/murmur/murmur_appengine.go, https://github.com/scylladb/gocql/blob/master/internal/murmur/murmur_unsafe.go

@dkropachev what about this?

@dkropachev
Copy link
Collaborator

dkropachev commented Feb 20, 2025

Not sure what to do with these tags:

* `tablet` https://github.com/scylladb/gocql/blob/master/tablet_integration_test.go

Let's make them part of integration suit, change test to check if tablets are supported and ignore if it not.

To be deleted

let's drop it, it is useless.

Drop it.

Let's keep them, but please create an issue on evaluating if this is really needed.

@sylwiaszunejko
Copy link
Collaborator Author

sylwiaszunejko commented Feb 20, 2025

Not sure what to do with these tags:

* `tablet` https://github.com/scylladb/gocql/blob/master/tablet_integration_test.go

Let's make them part of integration suit, change test to check if tablets are supported and ignore if it not.

@dkropachev But the cluster used for those tests is different, 3 nodes one instead of one node for the rest of integration tests

@dkropachev
Copy link
Collaborator

dkropachev commented Feb 20, 2025

Not sure what to do with these tags:

* `tablet` https://github.com/scylladb/gocql/blob/master/tablet_integration_test.go

Let's make them part of integration suit, change test to check if tablets are supported and ignore if it not.

@dkropachev But the cluster used for those tests is different, 3 nodes one instead of one node for the rest of integration tests

Let's make run rest of them on 3 node cluster, #400

@sylwiaszunejko
Copy link
Collaborator Author

Let's keep them, but please create an issue on evaluating if this is really needed.

Issue created: #402

About tablets tests and #400 I will address those things in separate PR, is that alright?

1. Remove `cassandra`, `scylla`, `all` tags, leave only
`unit` and `integration` tags in those files.
2. Drop `!scylla` files.
3. Change tags in worksflow running integration test in CI.
@dkropachev dkropachev merged commit a5bb9e2 into scylladb:master Feb 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set test files into order
2 participants