-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set test files into order #399
Conversation
@sylwiaszunejko , there are some tests in |
@dkropachev what tests do you mean? Shouldn't some tests fail if this is the case? |
I saw them failing on the pipeline, now it is all good. |
@sylwiaszunejko , feel free to merge it |
@dkropachev what about this? |
Let's make them part of integration suit, change test to check if tablets are supported and ignore if it not. To be deleted let's drop it, it is useless. Drop it.
Let's keep them, but please create an issue on evaluating if this is really needed. |
@dkropachev But the cluster used for those tests is different, 3 nodes one instead of one node for the rest of integration tests |
Let's make run rest of them on 3 node cluster, #400 |
1. Remove `cassandra`, `scylla`, `all` tags, leave only `unit` and `integration` tags in those files. 2. Drop `!scylla` files. 3. Change tags in worksflow running integration test in CI.
8b06a7c
to
2cbf178
Compare
cassandra
,scylla
,all
tags, leave onlyunit
andintegration
tags in those files.!scylla
files.Fixes: #397