Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(graphs-views): show predefined list of graphs #566

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

soyacz
Copy link
Collaborator

@soyacz soyacz commented Jan 3, 2025

Users are allowed to create 'Graph Views' which can store specific
graphs. Created Graph Views are visible in test's graph window and can
be selected for quick look on saved graphs list. This way saving time
for playing with filters.

Graph Views may have a name and description.

closes: #554

Main View with all the graphs:
image

When View is activated:
image

Adding new view:
image

Graphs may be added/removed by left top corner button (with tooltip).
Filters are created for each Graph View and work within it.

@soyacz soyacz requested review from fruch and k0machi January 3, 2025 10:48
@soyacz soyacz force-pushed the graphs-views branch 2 times, most recently from 253f2bd to d0e4d1f Compare January 7, 2025 14:48
@soyacz soyacz requested a review from k0machi January 9, 2025 09:45
@soyacz
Copy link
Collaborator Author

soyacz commented Jan 13, 2025

@fruch WDYT? Is it good enough?

@soyacz soyacz force-pushed the graphs-views branch 2 times, most recently from 9a561b9 to 99b2f80 Compare January 13, 2025 15:21
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To reduce complexity in code and enable filters component reuse.
Users are allowed to create 'Graph Views' which can store specific
graphs. Created Graph Views are visible in test's graph window and can
be selected for quick look on saved graphs list. This way saving time
for playing with filters.

Graph Views may have a name and description.

closes: scylladb#554
@soyacz soyacz merged commit 681f2e6 into scylladb:master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphs Views for fast graphs filtering
3 participants