Fix the version set in the pom.xml for a release #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the publish workflow works, I noticed that the published pom.xml file still contains a confusing version number. See e.g. https://repo1.maven.org/maven2/com/scylladb/alternator/load-balancing/1.0.0/load-balancing-1.0.0.pom (Which incorrectly sets the version to `1.0.0-SNAPSHOT` instead of `1.0.0`) This might be a problem because tooling may use the wrong version. See e.g. https://central.sonatype.com/artifact/com.scylladb.alternator/load-balancing/versions We fix that by using the `versions-maven-plugin` and changing the version in the pom.xml file before running the `deploy` command. See the documentation: https://www.mojohaus.org/versions/versions-maven-plugin/set-mojo.html
yaronkaikov
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the publish workflow works, I noticed that the published pom.xml file still contains a confusing version number. See e.g.
https://repo1.maven.org/maven2/com/scylladb/alternator/load-balancing/1.0.0/load-balancing-1.0.0.pom
(Which incorrectly sets the version to
1.0.0-SNAPSHOTinstead of1.0.0)This might be a problem because tooling may use the wrong version. See e.g.
https://central.sonatype.com/artifact/com.scylladb.alternator/load-balancing/versions
We fix that by using the
versions-maven-pluginand changing the version in the pom.xml file before running thedeploycommand.See the documentation: https://www.mojohaus.org/versions/versions-maven-plugin/set-mojo.html