Skip to content

plot continous column render labels #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 26, 2025

Conversation

ArneDefauw
Copy link
Contributor

Fix for #443

@ArneDefauw ArneDefauw marked this pull request as draft April 8, 2025 14:33
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (667f430) to head (a9b8c10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   84.92%   85.00%   +0.08%     
==========================================
  Files           8        8              
  Lines        1784     1794      +10     
==========================================
+ Hits         1515     1525      +10     
  Misses        269      269              
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/render.py 96.47% <100.00%> (+0.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArneDefauw ArneDefauw marked this pull request as ready for review April 11, 2025 06:45
@LucaMarconato
Copy link
Member

Thanks for the fix @ArneDefauw, works great! I'll add my review comments.

@LucaMarconato
Copy link
Member

LucaMarconato commented Apr 26, 2025

I added tests for the continuous case and for the categorical case (see below):
Screenshot 2025-04-26 at 16 04 08
Labels_can_handle_dropping_small_labels_after_rasterize_categorical

There is still one line that is not covered by tests, I will add a comment in the code. All covered!

@LucaMarconato
Copy link
Member

I uploaded the artifacts from my usual conda env instead of the Docker env I use to simulate the GitHub Actions. I will reupload.

Copy link
Member

@LucaMarconato LucaMarconato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@LucaMarconato LucaMarconato merged commit a005bec into scverse:main Apr 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants