Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IF images for Visium HD #261

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

quentinblampey
Copy link
Contributor

Closes #258 with the simple fix we discussed @LucaMarconato!

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 50.35%. Comparing base (c4f6cf7) to head (bc5352d).
Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/visium_hd.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   43.68%   50.35%   +6.66%     
==========================================
  Files          23       26       +3     
  Lines        2353     2647     +294     
==========================================
+ Hits         1028     1333     +305     
+ Misses       1325     1314      -11     
Files with missing lines Coverage Δ
src/spatialdata_io/readers/visium_hd.py 17.97% <0.00%> (-0.32%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Member

@LucaMarconato LucaMarconato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@LucaMarconato LucaMarconato merged commit 83e34c0 into scverse:main Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visium HD immunofluorescence image
3 participants