Skip to content

Visium HD: handle IF images - #261

Merged
LucaMarconato merged 1 commit into
scverse:mainfrom
quentinblampey:visium_hd_if
Jan 14, 2025
Merged

LucaMarconato merged 1 commit into
scverse:mainfrom
quentinblampey:visium_hd_if

Conversation

@quentinblampey

Copy link
Copy Markdown
Contributor

Closes #258 with the simple fix we discussed @LucaMarconato!

@codecov-commenter

codecov-commenter commented Jan 14, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 50.35%. Comparing base (c4f6cf7) to head (bc5352d).
Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/visium_hd.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   43.68%   50.35%   +6.66%     
==========================================
  Files          23       26       +3     
  Lines        2353     2647     +294     
==========================================
+ Hits         1028     1333     +305     
+ Misses       1325     1314      -11     
Files with missing lines Coverage Δ
src/spatialdata_io/readers/visium_hd.py 17.97% <0.00%> (-0.32%) ⬇️

... and 2 files with indirect coverage changes

@LucaMarconato LucaMarconato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@LucaMarconato
LucaMarconato merged commit 83e34c0 into scverse:main Jan 14, 2025
@LucaMarconato LucaMarconato changed the title Handle IF images for Visium HD Visium HD: handle IF images Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visium HD immunofluorescence image

3 participants