sc.pp.subsample, allow for sampling with replacement

[AlexAdrian-Hamazaki]

What kind of feature would you like to request?

Additional function parameters / changed functionality / changed defaults?

Please describe your wishes

Currently sc.pp.subsample does not allow for sampling with replacement.

When n_obs is provided, and it is larger than the size of the adata object, an error message from numpy.random.choice is given.
"obs_indices = np.random.choice(old_n_obs, size=new_n_obs, replace=False)"

It seems like replace is automatically set to False.

It would be great if sc.pp.subsample provided a paramater to change the np.random.choice's 'replace' parameter to True.

[ivirshup]

It looks like there is an old stalled PR for this.

• Add replace option to subsample and rename function to sample #943

Would you want to pick that up?