Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo metadata #307

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Fix repo metadata #307

merged 7 commits into from
Sep 2, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Sep 2, 2024

It’s used here: https://github.com/pydata/pydata-sphinx-theme/blob/15494ecd48147e03d57fd462c1eaf8fb5aeb67d2/src/pydata_sphinx_theme/edit_this_page.py#L51-L55

Alternatively, we could define __repo_url for a more DRY cookiecutter (double underscore means that the user doesn’t get asked, but {{substitution}} still happens)

Copy link

github-actions bot commented Sep 2, 2024

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#144

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. I'm fine with this. Verbose but explicit.

@flying-sheep flying-sheep merged commit f0a10d4 into main Sep 2, 2024
7 checks passed
@flying-sheep flying-sheep deleted the fix-repo branch September 2, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants