Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_modules to .gitignore #277

Merged
merged 1 commit into from
May 18, 2024
Merged

Add node_modules to .gitignore #277

merged 1 commit into from
May 18, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Apr 23, 2024

No description provided.

Copy link

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#121

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@flying-sheep
Copy link
Member

Maybe we soon don't need prettier anymore: https://biomejs.dev/

It doesn't have yaml support yet though

@Zethson
Copy link
Member Author

Zethson commented Apr 24, 2024

I'm actually hoping that the Astral reimplements the rules in Ruff.

@ivirshup
Copy link
Member

I have just started removing prettier from my setups, I'd probably be more up for that here

@flying-sheep
Copy link
Member

@Zethson Ruff does Python and things that contain Python (docstrings, Jupyter notebooks). We use prettier for JSON, YAML, and in some cases Markdown.

@ivirshup what are you replacing it with? Biome or something else?

Copy link
Collaborator

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't harm to have node_modules in .gitignore.

@grst
Copy link
Collaborator

grst commented May 18, 2024

Merging this. Opening separate issue to discuss prettier alternatives.

This was referenced May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants