Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality #644

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Equality #644

wants to merge 2 commits into from

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Nov 11, 2021

Move equality things out of the test module and maybe use in __eq__

One idea for __eq__: it could return an object with a __bool__ method that returns if there are any changes, but also allows descending into the attributes.

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #644 (92fbf6c) into master (19ade7a) will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   83.40%   83.42%   +0.01%     
==========================================
  Files          30       33       +3     
  Lines        4135     4144       +9     
==========================================
+ Hits         3449     3457       +8     
- Misses        686      687       +1     
Impacted Files Coverage Δ
anndata/testing/equality.py 93.25% <93.25%> (ø)
anndata/testing/__init__.py 100.00% <100.00%> (ø)
anndata/testing/exceptions.py 100.00% <100.00%> (ø)
anndata/tests/helpers.py 96.51% <100.00%> (+1.24%) ⬆️
anndata/_core/merge.py 93.25% <0.00%> (-0.31%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant