[WIP] Proof of concept for not converting objects to strings #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #115. This just preserves objects during
strings_to_categoricals
.This will change behaviour for cases where there we mixed types in a
Series
(like:["abc", 0.6]
), but I'm not sure if that's a common case. It will still convert if there are missing values.This still converts things to strings for writing, where it should probably error or at least warn.