Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Proof of concept for not converting objects to strings #310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ivirshup
Copy link
Member

Potentially fixes #115. This just preserves objects during strings_to_categoricals.

This will change behaviour for cases where there we mixed types in a Series (like: ["abc", 0.6]), but I'm not sure if that's a common case. It will still convert if there are missing values.

This still converts things to strings for writing, where it should probably error or at least warn.

@LuckyMD
Copy link

LuckyMD commented Jan 29, 2020

I remember having issues when having object as dtype in obs. I'm not sure what it was... but I remember there was a long back and forth with me being clueless as to why sth didn't work. Not very helpful atm... but just a heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing detections of strings from is_string_dtype
2 participants