Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): remove sparse data scipy inheritance #1927

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ilan-gold
Copy link
Contributor

  • Closes #
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold marked this pull request as draft March 20, 2025 21:49
@ilan-gold ilan-gold force-pushed the ig/remove_sparse_inheritance branch from a12700b to eac05cf Compare March 21, 2025 14:23
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 28.08219% with 105 lines in your changes missing coverage. Please review.

Project coverage is 26.81%. Comparing base (098639e) to head (c1be255).

Files with missing lines Patch % Lines
src/anndata/_core/sparse_dataset.py 28.27% 104 Missing ⚠️
src/anndata/compat/__init__.py 0.00% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (26.81%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (098639e) and HEAD (c1be255). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (098639e) HEAD (c1be255)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1927       +/-   ##
===========================================
- Coverage   86.51%   26.81%   -59.70%     
===========================================
  Files          45       44        -1     
  Lines        6798     6773       -25     
===========================================
- Hits         5881     1816     -4065     
- Misses        917     4957     +4040     
Files with missing lines Coverage Δ
src/anndata/compat/__init__.py 9.50% <0.00%> (-73.68%) ⬇️
src/anndata/_core/sparse_dataset.py 35.60% <28.27%> (-56.78%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant