fix outer concatenation along var when varm is not empty #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1911 +/- ##
==========================================
- Coverage 86.51% 84.41% -2.10%
==========================================
Files 45 45
Lines 6798 6802 +4
==========================================
- Hits 5881 5742 -139
- Misses 917 1060 +143
🚀 New features to boost your workflow:
|
ilan-gold
approved these changes
Mar 25, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Mar 25, 2025
ilan-gold
added a commit
that referenced
this pull request
Mar 25, 2025
… empty (#1936) Co-authored-by: ilia-kats <[email protected]> Co-authored-by: Ilan Gold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the code assumed that there is only one concatenation axis throughout. However, when concatenating varm, there is a difference between the AnnData concatenation axis (1) and the varm concatenation axis (0).