Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): allow zarr v3 writing #1892

Merged
merged 136 commits into from
Mar 28, 2025
Merged

(feat): allow zarr v3 writing #1892

merged 136 commits into from
Mar 28, 2025

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Mar 6, 2025 •
edited
Loading

TODO:

ilan-gold and others added 30 commits October 21, 2024 16:51
@ilan-gold
(wip): support for new zarr version
0840150
@ilan-gold
Merge branch 'main' into ig/zarr_v3
7876318
@ilan-gold
(chore): create setting for write version
892888e
@ilan-gold
(fix): pathing issue
4846e7d
@ilan-gold
(chore): use open_group
4eeb1ec
@ilan-gold
(fix): another zarr.open
19b7f41
@ilan-gold
(fix): zarr_write_version -> zarr_write_format
aafcc7a
@ilan-gold
(feat): batched reading for sparse
215c761
@ilan-gold
(fix): object codec
7cf74b2
@ilan-gold
Merge branch 'main' into ig/zarr_v3
fb4fabc
@ilan-gold
(fix): revert compressed vectors
4594c52
@ilan-gold
(feat): scalar support
f465a95
@ilan-gold
(fix): open_group for v3
65e736a
@ilan-gold
(fix): backed sparse copy method
ae8bd4a
@ilan-gold
(fix): add speed-up for zarr by batching indexing
5c2a8b3
@ilan-gold
(fix): no __len__ on new zarr arrays
434d15c
@ilan-gold
(fix): some v3 fixes
688ff9d
@flying-sheep
Merge branch 'main' into ig/zarr_v3
14a226d
@flying-sheep
Specify mode with kwarg
4defc32
@flying-sheep
chore: typing fixes
1687554
@ilan-gold
Merge branch 'ig/zarr_v3' of github.com:scverse/anndata into ig/zarr_v3
a160642
@ilan-gold
(fix): more create_dataset args
ff52eb3
@flying-sheep
Merge branch 'main' into ig/zarr_v3
340539f
@flying-sheep
format->version
1316c12
@flying-sheep
clear properly
2b19ba1
@flying-sheep
dynamic format/version
a12862a
@flying-sheep
Centralize version comparison
f85b027
@flying-sheep
Fix most create_dataset errors
d31d2e5
@flying-sheep
unpin zarr everywhere
f9830ae
@flying-sheep
Almost fix docs
f1ca6f7
@ilan-gold ilan-gold force-pushed the ig/allow_v3_writing branch from 251981f to 779c957 Compare March 21, 2025 13:24
@ilan-gold ilan-gold marked this pull request as ready for review March 25, 2025 10:13
@ilan-gold ilan-gold requested a review from flying-sheep March 25, 2025 13:30
flying-sheep
flying-sheep reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some preliminary comments, will look properly next time

flying-sheep
flying-sheep approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Apart from the check in the compression test that I don’t understand, there are just a few formatting things!

@ilan-gold ilan-gold merged commit 3e2ddec into main Mar 28, 2025
16 of 17 checks passed
@ilan-gold ilan-gold deleted the ig/allow_v3_writing branch March 28, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep approved these changes

Assignees
No one assigned
Labels
skip-gpu-ci
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilan-gold @flying-sheep