-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): adopt scientific python deprecation schedule #1768
Open
ilan-gold
wants to merge
30
commits into
main
Choose a base branch
from
ig/scientific_python_deprecation_schedule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f2af154
(chore): migrate to only checking `cs{r,c}_matrix` instead of `spmatrix`
ilan-gold 4f97787
(chore): alter tests as well
ilan-gold 8ea1c4e
(chore): release note
ilan-gold 0253072
(chore): update for scientific python deprecation schedule
ilan-gold b547a2c
(chore): change name in azure pipeline
ilan-gold fb686af
(fix): use `https`
ilan-gold b891b7c
(fix): remove `git@`
ilan-gold 7ab8eee
(chore): remove py3.11 checks
ilan-gold 94c1cdf
(fix): remove scanpy for now
ilan-gold 5d45a79
Merge branch 'main' into ig/scientific_python_deprecation_schedule
ilan-gold 2e53c19
Merge branch 'main' into ig/scientific_python_deprecation_schedule
ilan-gold 51c26a4
(fix): correct h5py version
ilan-gold 7286691
(fix): h5py 3.8
ilan-gold b77beaa
(fix): respect `pyproject.toml` max versions
ilan-gold 3f18c10
(fix): no `asv` for python 3.13
ilan-gold c8fedea
(fix): install command
ilan-gold 2e705f8
(fix): path re-route
ilan-gold 23ca307
(fix): remove `add_note`
ilan-gold f2200ba
(fix): gpu ci
ilan-gold 00e972f
(fix): no `eye_array` in 1.11
ilan-gold 3cd8330
(fix): filter h5py-numpy deprecation
ilan-gold 5768b12
(fix): concatenation bugs
ilan-gold ee7faa9
(fix): still an issue with matrices!
ilan-gold 60e1149
(fix): minimum version needs to be higher of dask
ilan-gold 06d11e3
(fix): try different constraint
ilan-gold 94d08eb
(chore): remove `CAN_USE_SPARSE_ARRAY`
ilan-gold 296b6c9
(chore): remove duplicated lines
ilan-gold 2740341
(chore): release note
ilan-gold 3f0afae
(fix): bring back skip for array allocation
ilan-gold 3351c43
(fix): PR for relnote
ilan-gold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Tighten usage of {class}`scipy.sparse.spmatrix` for describing sparse matrices in types and instance checks to only {class}`scipy.sparse.csr_matrix` and {class}`scipy.sparse.csc_matrix` {user}`ilan-gold` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Adopt the Scientific Python [deprecation schedule](https://scientific-python.org/specs/spec-0000/) {user}`ilan-gold` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flying-sheep I think this is a bug, no? The min-deps are created without respect for upper bounds so the constraints can end up not including the upper bounds because the min-deps script doesn't care about it? I think this is the correct fix given the fact that the script is called "min-deps" and not "min-deps-with-upper-bound" but maybe I'm off