fix: update Scryfall integration with custom User-Agent, rate limiting, and robust error handling (credit also to SteveEisner)#33
Open
DigitalSecurityMod wants to merge 1 commit into
Conversation
…g, and robust error handling (credit also to SteveEisner)
|
Looks like rate limits have been added to main in 5f66fa1 (which is an MTG Jump Start value calculator: https://docs.google.com/spreadsheets/d/1s0iw1gHo4_68HiGd5LIGNh8eqz8wrfZNlSl5E92yDiw/edit?gid=1671756194#gid=1671756194) |
|
I was just troubleshooting an old scryfall sheet I had and ran across this PR. Did you ever add the Marvel jumpstart series to your spreadsheet @SteveEisner? I won't go make one if you already have it done (assuming you're willing to share) |
|
Sorry no - no marvel Jumpstart in there. TBH I wasn't following mtg news, and didn't even know there was a new Jumpstart set! I'll read up on it, but probably won't add the set unless I buy some of the product ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked separately from @SteveEisner, but liked his configurable header values. In addition to applying the same updates Steve made to the mandatory new headers, I also added additional error and exception handling. Additionally, added soem graceful handling of rate limits