Skip to content

chore: remove outdated TODO and stabilize proof roundtrip test #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ocheretovich wants to merge 3 commits into
base: develop
Choose a base branch
from
+1 −2
Open

chore: remove outdated TODO and stabilize proof roundtrip test #1775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e88ba1c
chore: remove outdated TODO comment in version resolution
Ocheretovich Dec 28, 2025
408389d
tests: skip proof roundtrip test when testdata is missing
Ocheretovich Dec 28, 2025
19d814a
tests: mark proof roundtrip test as ignored without fixtures
Ocheretovich Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions coordinator/internal/utils/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ const (
)

// version get the version for the chain instance
//
// TODO: This is not foolproof and does not cover all scenarios.
func Version(hardForkName string, ValidiumMode bool) (uint8, error) {

var domain, stfVersion uint8
Expand Down
1 change: 1 addition & 0 deletions crates/libzkp/src/proofs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ mod tests {
use super::*;

#[test]
#[ignore = "requires testdata directory with chunk-proof.json, batch-proof.json, bundle-proof.json"]
fn test_roundtrip() -> eyre::Result<()> {
macro_rules! assert_roundtrip {
($fd:expr, $proof:ident) => {
Expand Down