Skip to content

Conversation

@Thegaram
Copy link
Contributor

Add a new version of the L1GasPriceOracle predeploy, to be activated in the GalileoV2 hard fork.

  • Add Galileo activation.
  • Deprecate penaltyThreshold.
  • Update range check for penaltyFactor.

@Thegaram Thegaram requested review from Copilot and zimpha November 26, 2025 08:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces support for the GalileoV2 hard fork by adding a new version of the L1 gas price calculation logic. The penalty threshold parameter is deprecated in favor of a simplified penalty calculation, and the penalty factor validation is relaxed to allow a wider range of values.

Key changes:

  • Added enableGalileo() function and isGalileo flag to activate the new fork
  • Deprecated penaltyThreshold parameter and its setter function
  • Updated penaltyFactor validation to only check for zero (removing upper bound)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/L2/predeploys/L1GasPriceOracle.sol Implements Galileo fork logic with new _getL1FeeGalileo() function, deprecates penalty threshold, and updates penalty factor validation
src/L2/predeploys/IL1GasPriceOracle.sol Marks penaltyThreshold as deprecated in interface documentation and removes the threshold update event
src/test/L1GasPriceOracle.t.sol Adds testGetL1FeeGalileo() test and comments out deprecated penalty threshold usage in existing tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Thegaram Thegaram merged commit 6c25be6 into main Nov 26, 2025
5 checks passed
@Thegaram Thegaram deleted the feat-galileo-gas-price-oracle branch November 26, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants