feat: require top-level call to commitAndFinalizeBatch #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our L1 consolidation relies on decoding transaction calldata. If calls to
commitAndFinalizeBatchare done via a smart contract account, for example, then this decoding will fail. It is easier to disallow it than to implement internal transaction fetching and decoding in the indexers.Technically, this is also a requirement for
commitBatchesandfinalizeBundlePostEuclidV2. But the risk is bigger for permissionless submission (commitAndFinalizeBatch).