Skip to content

chore: improve database interface #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

frisitano
Copy link
Collaborator

Overview

This PR removes sea_orm::DbErr from the Database public interface such that in the error case we always return a DatabaseError.

@frisitano frisitano requested a review from greged93 April 24, 2025 18:27
@frisitano frisitano added this to the Milestone 5 milestone Apr 24, 2025
@frisitano frisitano added this to Reth Apr 24, 2025
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frisitano frisitano merged commit 08cf165 into main Apr 28, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this to Done in Reth Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants