Skip to content

feat: introduce signer #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025
Merged

feat: introduce signer #79

merged 6 commits into from
Apr 29, 2025

Conversation

frisitano
Copy link
Collaborator

closes: #61

Verified

This commit was signed with the committer’s verified signature.
@frisitano frisitano added this to Reth Apr 24, 2025
@frisitano frisitano added this to the Milestone 5 milestone Apr 24, 2025

Verified

This commit was signed with the committer’s verified signature.
@frisitano frisitano marked this pull request as ready for review April 28, 2025 09:33

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@frisitano frisitano requested a review from greged93 April 28, 2025 11:01
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general comment: the Signer runs as a separate task, which moves away from the RNM centric view. I'm fine with it but why go in this direction? Do you think we should move more components to separate tasks (related to #57)?

@frisitano
Copy link
Collaborator Author

@greged93 The reason for moving the Signer into a separate task is that signing is order-independent. I.e. we don't care if we perform a block import, index, or build a block before we sign. As such, we can delegate polling to the tokio executor. We only need to keep components in the same task if the ordering of component execution has a tangible impact on the system as a whole.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@frisitano frisitano requested a review from greged93 April 29, 2025 09:33
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frisitano frisitano merged commit c14a138 into main Apr 29, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this to Done in Reth Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Sequencer] Block Signing
2 participants