Skip to content

chore: introduce IsReorg type to make function signature more parsable #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frisitano merged 1 commit into from
Apr 24, 2025
Merged

chore: introduce IsReorg type to make function signature more parsable #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/engine/src/future/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ type BlockImportFuture = Pin<
>,
>;

// A boolean type indicating if the L1 consolidation job resulted in a reorg.
type IsReorg = bool;

/// A future that represents an L1 consolidation job.
type L1ConsolidationFuture =
Pin<Box<dyn Future<Output = Result<(BlockInfo, bool, BatchInfo), EngineDriverError>> + Send>>;
type L1ConsolidationFuture = Pin<
Box<dyn Future<Output = Result<(BlockInfo, IsReorg, BatchInfo), EngineDriverError>> + Send>,
>;

/// A future that represents a payload building job.
type PayloadBuildingJobFuture =
Expand Down Expand Up @@ -197,7 +201,7 @@ async fn handle_payload_attributes<EC, P>(
safe_block_info: BlockInfo,
mut fcs: AlloyForkchoiceState,
payload_attributes: ScrollPayloadAttributesWithBatchInfo,
) -> Result<(BlockInfo, bool, BatchInfo), EngineDriverError>
) -> Result<(BlockInfo, IsReorg, BatchInfo), EngineDriverError>
where
EC: ScrollEngineApi + Unpin + Send + Sync + 'static,
P: ExecutionPayloadProvider + Unpin + Send + Sync + 'static,
Expand Down