-
Notifications
You must be signed in to change notification settings - Fork 1
feat: consensus signer #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
29b193a
to
7e3ef68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have some questions:
- How does this behave in the context of reorgs?
- How do we remove authorized signers?
For now, the authorized signer will be pulled from the L1 every latest block, meaning reorgs will just cause it to repull the latest signer at the next block. We should consider reorgs when we use logs to fetch signer updates.
Currently the node just reads the signer from the L1, so removing a signer would require an update of the L1 contract. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@greged93 can you open an issue on the smart contracts repo to introduce events for removal and addition of signers please? |
* feat: add l1 start block to the node config * feat: RN as scroll addon (#111) * feat: refactor for node addons * merge upstream * lint * improvements * merge main * lint * lint * feedback * feat: merge changes * feat: merge changes --------- Co-authored-by: frisitano <[email protected]>
Adds an polling update of the consensus configuration on the watcher, propagating updates across the node to reach the consensus.
Resolves #72