Skip to content

feat: consensus signer #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 16, 2025
Merged

feat: consensus signer #113

merged 9 commits into from
May 16, 2025

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented May 14, 2025

Adds an polling update of the consensus configuration on the watcher, propagating updates across the node to reach the consensus.

Resolves #72

@greged93 greged93 requested a review from frisitano May 14, 2025 08:19
@greged93 greged93 force-pushed the feat/consensus-signer branch from 29b193a to 7e3ef68 Compare May 14, 2025 08:23
frisitano
frisitano previously approved these changes May 15, 2025
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have some questions:

  • How does this behave in the context of reorgs?
  • How do we remove authorized signers?

@greged93
Copy link
Collaborator Author

greged93 commented May 15, 2025

How does this behave in the context of reorgs?

For now, the authorized signer will be pulled from the L1 every latest block, meaning reorgs will just cause it to repull the latest signer at the next block. We should consider reorgs when we use logs to fetch signer updates.

How do we remove authorized signers?

Currently the node just reads the signer from the L1, so removing a signer would require an update of the L1 contract.

frisitano
frisitano previously approved these changes May 16, 2025
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frisitano
Copy link
Collaborator

@greged93 can you open an issue on the smart contracts repo to introduce events for removal and addition of signers please?

@greged93
Copy link
Collaborator Author

* feat: add l1 start block to the node config

* feat: RN as scroll addon (#111)

* feat: refactor for node addons

* merge upstream

* lint

* improvements

* merge main

* lint

* lint

* feedback

* feat: merge changes

* feat: merge changes

---------

Co-authored-by: frisitano <[email protected]>
@greged93 greged93 merged commit fb06d45 into main May 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Consensus] Track system contract signer
2 participants