Skip to content
GitHub Actions / Clippy (1.56.1) failed Dec 27, 2023 in 1s

Clippy (1.56.1)

60 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 60
Warning 0
Note 0
Help 0

Versions

  • rustc 1.73.0-nightly (a6f8aa5a0 2023-08-11)
  • cargo 1.73.0-nightly (d78bbf4bd 2023-08-03)
  • clippy 0.1.73 (a6f8aa5 2023-08-11)

Annotations

Check failure on line 12 in halo2_proofs/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `PrimeField`

error: unused import: `PrimeField`
  --> halo2_proofs/src/poly/domain.rs:12:30
   |
12 |     ff::{BatchInvert, Field, PrimeField},
   |                              ^^^^^^^^^^

Check failure on line 9 in halo2_proofs/src/poly/commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `Group`

error: unused import: `Group`
 --> halo2_proofs/src/poly/commitment.rs:9:20
  |
9 | use group::{Curve, Group};
  |                    ^^^^^

Check failure on line 18 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `BitViewSized`

error: unused import: `BitViewSized`
  --> halo2_proofs/src/plonk/mv_lookup/prover.rs:18:10
   |
18 | use ff::{BitViewSized, PrimeField, PrimeFieldBits, WithSmallOrderMulGroup};
   |          ^^^^^^^^^^^^

Check failure on line 12 in halo2_proofs/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `rayon::prelude::ParallelIterator`

error: unused import: `rayon::prelude::ParallelIterator`
  --> halo2_proofs/src/plonk/evaluation.rs:12:5
   |
12 | use rayon::prelude::ParallelIterator;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 15 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `std::hash::Hasher`

error: unused import: `std::hash::Hasher`
  --> halo2_proofs/src/plonk/circuit.rs:15:5
   |
15 | use std::hash::Hasher;
   |     ^^^^^^^^^^^^^^^^^

Check failure on line 1303 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

no method named `build_ordered_mapping` found for enum `std::option::Option` in the current scope

error[E0599]: no method named `build_ordered_mapping` found for enum `std::option::Option` in the current scope
    --> halo2_proofs/src/dev.rs:1303:28
     |
1303 |         prover.permutation.build_ordered_mapping();
     |                            ^^^^^^^^^^^^^^^^^^^^^ method not found in `Option<Assembly>`
     |
note: the method `build_ordered_mapping` exists on the type `plonk::permutation::keygen::Assembly`
    --> halo2_proofs/src/plonk/permutation/keygen.rs:260:5
     |
260  |     pub fn build_ordered_mapping(&mut self) {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: consider using `Option::expect` to unwrap the `plonk::permutation::keygen::Assembly` value, panicking if the value is an `Option::None`
     |
1303 |         prover.permutation.expect("REASON").build_ordered_mapping();
     |                           +++++++++++++++++

Check failure on line 329 in halo2_proofs/src/dev/graph/layout.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

failed to resolve: use of undeclared type `F`

error[E0433]: failed to resolve: use of undeclared type `F`
   --> halo2_proofs/src/dev/graph/layout.rs:329:8
    |
329 |     Ok(F::ZERO)
    |        ^
    |        |
    |        use of undeclared type `F`
    |        help: a trait with a similar name exists: `Fn`

Check failure on line 325 in halo2_proofs/src/dev/graph/layout.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

failed to resolve: use of undeclared type `F`

error[E0433]: failed to resolve: use of undeclared type `F`
   --> halo2_proofs/src/dev/graph/layout.rs:325:8
    |
325 |     Ok(F::ZERO)
    |        ^
    |        |
    |        use of undeclared type `F`
    |        help: a trait with a similar name exists: `Fn`

Check failure on line 3 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `ff::Field`

error: unused import: `ff::Field`
 --> halo2_proofs/src/helpers.rs:3:5
  |
3 | use ff::Field;
  |     ^^^^^^^^^

Check failure on line 29 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `group::Group`

error: unused import: `group::Group`
  --> halo2_proofs/src/dev.rs:29:5
   |
29 | use group::Group;
   |     ^^^^^^^^^^^^

Check failure on line 13 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `group::Group`

error: unused import: `group::Group`
  --> halo2_proofs/src/dev.rs:13:5
   |
13 | use group::Group;
   |     ^^^^^^^^^^^^

Check failure on line 8 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `std::time::Instant`

error: unused import: `std::time::Instant`
 --> halo2_proofs/src/dev.rs:8:5
  |
8 | use std::time::Instant;
  |     ^^^^^^^^^^^^^^^^^^

Check failure on line 4 in halo2_proofs/src/poly/kzg/multiopen/gwc/verifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused imports: `CurveAffine`, `eval_polynomial`, `lagrange_interpolate`

error: unused imports: `CurveAffine`, `eval_polynomial`, `lagrange_interpolate`
 --> halo2_proofs/src/poly/kzg/multiopen/gwc/verifier.rs:4:25
  |
4 | use crate::arithmetic::{eval_polynomial, lagrange_interpolate, powers, CurveAffine};
  |                         ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^^          ^^^^^^^^^^^

Check failure on line 11 in halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `Field`

error: unused import: `Field`
  --> halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs:11:10
   |
11 | use ff::{Field, PrimeField};
   |          ^^^^^

Check failure on line 2 in halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused imports: `CurveAffine`, `eval_polynomial`

error: unused imports: `CurveAffine`, `eval_polynomial`
 --> halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs:2:25
  |
2 | use crate::arithmetic::{eval_polynomial, kate_division, powers, CurveAffine};
  |                         ^^^^^^^^^^^^^^^                         ^^^^^^^^^^^

Check failure on line 7 in halo2_proofs/src/poly/ipa/multiopen.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `arithmetic::CurveAffine`

error: unused import: `arithmetic::CurveAffine`
 --> halo2_proofs/src/poly/ipa/multiopen.rs:7:13
  |
7 | use crate::{arithmetic::CurveAffine, poly::query::Query, transcript::ChallengeScalar};
  |             ^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 13 in halo2_proofs/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `Group`

error: unused import: `Group`
  --> halo2_proofs/src/poly/domain.rs:13:5
   |
13 |     Group,
   |     ^^^^^

Check failure on line 10 in halo2_proofs/src/poly/commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `CurveExt`

error: unused import: `CurveExt`
  --> halo2_proofs/src/poly/commitment.rs:10:32
   |
10 | use halo2curves::{CurveAffine, CurveExt};
   |                                ^^^^^^^^

Check failure on line 9 in halo2_proofs/src/poly/commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `Curve`

error: unused import: `Curve`
 --> halo2_proofs/src/poly/commitment.rs:9:13
  |
9 | use group::{Curve, Group};
  |             ^^^^^

Check failure on line 9 in halo2_proofs/src/plonk/verifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `CurveAffine`

error: unused import: `CurveAffine`
 --> halo2_proofs/src/plonk/verifier.rs:9:48
  |
9 | use crate::arithmetic::{compute_inner_product, CurveAffine};
  |                                                ^^^^^^^^^^^

Check failure on line 2 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `PrimeField`

error: unused import: `PrimeField`
 --> halo2_proofs/src/plonk/prover.rs:2:35
  |
2 | use ff::{Field, FromUniformBytes, PrimeField, WithSmallOrderMulGroup};
  |                                   ^^^^^^^^^^

Check failure on line 1 in halo2_proofs/src/plonk/vanishing/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `collections::HashMap`

error: unused import: `collections::HashMap`
 --> halo2_proofs/src/plonk/vanishing/prover.rs:1:11
  |
1 | use std::{collections::HashMap, iter};
  |           ^^^^^^^^^^^^^^^^^^^^

Check failure on line 4 in halo2_proofs/src/plonk/mv_lookup/verifier.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `ChallengeGamma`

error: unused import: `ChallengeGamma`
 --> halo2_proofs/src/plonk/mv_lookup/verifier.rs:4:41
  |
4 |     circuit::Expression, ChallengeBeta, ChallengeGamma, ChallengeTheta, ChallengeX,
  |                                         ^^^^^^^^^^^^^^

Check failure on line 487 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `std::time::Instant`

error: unused import: `std::time::Instant`
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:487:9
    |
487 |     use std::time::Instant;
    |         ^^^^^^^^^^^^^^^^^^

Check failure on line 486 in halo2_proofs/src/plonk/mv_lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused import: `std::collections::BTreeMap`

error: unused import: `std::collections::BTreeMap`
   --> halo2_proofs/src/plonk/mv_lookup/prover.rs:486:9
    |
486 |     use std::collections::BTreeMap;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^