Skip to content

Merge pull request #50 from scroll-tech/mockprover_fork #486

Merge pull request #50 from scroll-tech/mockprover_fork

Merge pull request #50 from scroll-tech/mockprover_fork #486

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Clippy (beta) succeeded Jul 6, 2023 in 0s

Clippy (beta)

10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 10
Note 0
Help 0

Versions

  • rustc 1.63.0 (4b91a6ea7 2022-08-08)
  • cargo 1.63.0 (fd9c4297c 2022-07-01)
  • clippy 0.1.63 (4b91a6e 2022-08-08)

Annotations

Check warning on line 674 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

cannot test inner items

warning: cannot test inner items
   --> halo2_proofs/tests/plonk_api.rs:674:5
    |
674 |     #[test]
    |     ^^^^^^^
    |
    = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 644 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

cannot test inner items

warning: cannot test inner items
   --> halo2_proofs/tests/plonk_api.rs:644:5
    |
644 |     #[test]
    |     ^^^^^^^
    |
    = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 599 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

cannot test inner items

warning: cannot test inner items
   --> halo2_proofs/tests/plonk_api.rs:599:5
    |
599 |     #[test]
    |     ^^^^^^^
    |
    = note: `#[warn(unnameable_test_items)]` on by default
    = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 558 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

redundant clone

warning: redundant clone
   --> halo2_proofs/tests/plonk_api.rs:558:39
    |
558 |             &[circuit.clone(), circuit.clone()],
    |                                       ^^^^^^^^ help: remove this
    |
    = note: `-W clippy::redundant-clone` implied by `-W clippy::all`
note: this value is dropped without further use
   --> halo2_proofs/tests/plonk_api.rs:558:32
    |
558 |             &[circuit.clone(), circuit.clone()],
    |                                ^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Check warning on line 675 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

function `test_plonk_api_ipa` is never used

warning: function `test_plonk_api_ipa` is never used
   --> halo2_proofs/tests/plonk_api.rs:675:8
    |
675 |     fn test_plonk_api_ipa() {
    |        ^^^^^^^^^^^^^^^^^^

Check warning on line 645 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

function `test_plonk_api_shplonk` is never used

warning: function `test_plonk_api_shplonk` is never used
   --> halo2_proofs/tests/plonk_api.rs:645:8
    |
645 |     fn test_plonk_api_shplonk() {
    |        ^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 180 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

function `unpack` is never used

warning: function `unpack` is never used
   --> halo2_proofs/src/helpers.rs:180:8
    |
180 | pub fn unpack(byte: u8, bits: &mut [bool]) {
    |        ^^^^^^

Check warning on line 170 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

function `pack` is never used

warning: function `pack` is never used
   --> halo2_proofs/src/helpers.rs:170:8
    |
170 | pub fn pack(bits: &[bool]) -> u8 {
    |        ^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 180 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

function `unpack` is never used

warning: function `unpack` is never used
   --> halo2_proofs/src/helpers.rs:180:8
    |
180 | pub fn unpack(byte: u8, bits: &mut [bool]) {
    |        ^^^^^^

Check warning on line 170 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

function `pack` is never used

warning: function `pack` is never used
   --> halo2_proofs/src/helpers.rs:170:8
    |
170 | pub fn pack(bits: &[bool]) -> u8 {
    |        ^^^^
    |
    = note: `#[warn(dead_code)]` on by default