Skip to content

Commit

Permalink
boundary offset lost when resolving conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
Velaciela committed Oct 25, 2023
1 parent 2b92df9 commit 3d44389
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions halo2_proofs/src/dev.rs
Original file line number Diff line number Diff line change
Expand Up @@ -781,11 +781,13 @@ impl<'a, F: Field> Assignment<F> for MockProver<'a, F> {
#[cfg(feature = "mock-batch-inv")]
let assigned = CellValue::from(val_res?);

Check failure on line 782 in halo2_proofs/src/dev.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

the trait bound `F: group::Group` is not satisfied

error[E0277]: the trait bound `F: group::Group` is not satisfied --> halo2_proofs/src/dev.rs:782:40 | 782 | let assigned = CellValue::from(val_res?); | --------------- ^^^^^^^^ the trait `group::Group` is not implemented for `F` | | | required by a bound introduced by this call | note: required for `dev::CellValue<F>` to implement `std::convert::From<plonk::assigned::Assigned<F>>` --> halo2_proofs/src/dev.rs:149:24 | 149 | impl<F: Group + Field> From<Assigned<F>> for CellValue<F> { | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ help: consider further restricting this bound | 487 | impl<'a, F: Field + group::Group> Assignment<F> for MockProver<'a, F> { | ++++++++++++++

*self
.advice
.get_mut(column.index())
.and_then(|v| v.get_mut(row))
.ok_or(Error::BoundsFailure)? = assigned;
if self.in_phase(column.column_type().phase) {
*self
.advice
.get_mut(column.index())
.and_then(|v| v.get_mut(row - self.rw_rows.start))
.expect("bounds failure") = assigned;
}

#[cfg(feature = "phase-check")]
// if false && self.current_phase.0 > column.column_type().phase.0 {
Expand Down

0 comments on commit 3d44389

Please sign in to comment.