Skip to content

Commit

Permalink
U
Browse files Browse the repository at this point in the history
  • Loading branch information
@silathdiir
silathdiir committed Jul 10, 2023
1 parent 103ce21 commit 229623c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions halo2_proofs/src/plonk.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ where

let permutation = permutation::VerifyingKey::read(reader, &cs.permutation, format)?;

/*
// read selectors
let selectors: Vec<Vec<bool>> = vec![vec![false; 1 << k]; cs.num_selectors]
.into_iter()
Expand All @@ -133,7 +132,6 @@ where
})
.collect::<io::Result<_>>()?;
let (cs, _) = cs.compress_selectors(selectors.clone());

Check warning on line 134 in halo2_proofs/src/plonk.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

redundant clone 

warning: redundant clone
   --> halo2_proofs/src/plonk.rs:134:54
    |
134 |         let (cs, _) = cs.compress_selectors(selectors.clone());
    |                                                      ^^^^^^^^ help: remove this
    |
    = note: `-W clippy::redundant-clone` implied by `-W clippy::all`
note: this value is dropped without further use
   --> halo2_proofs/src/plonk.rs:134:45
    |
134 |         let (cs, _) = cs.compress_selectors(selectors.clone());
    |                                             ^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Check warning on line 134 in halo2_proofs/src/plonk.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

redundant clone 

warning: redundant clone
   --> halo2_proofs/src/plonk.rs:134:54
    |
134 |         let (cs, _) = cs.compress_selectors(selectors.clone());
    |                                                      ^^^^^^^^ help: remove this
    |
    = note: `-W clippy::redundant-clone` implied by `-W clippy::all`
note: this value is dropped without further use
   --> halo2_proofs/src/plonk.rs:134:45
    |
134 |         let (cs, _) = cs.compress_selectors(selectors.clone());
    |                                             ^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
*/
Ok(Self::from_parts(
domain,
fixed_commitments,
Expand Down

0 comments on commit 229623c

Please sign in to comment.