Skip to content

resolve merge conflict #337

resolve merge conflict

resolve merge conflict #337

Triggered via push December 27, 2023 11:24
Status Success
Total duration 1m 0s
Artifacts

lints-beta.yml

on: push
Clippy (beta)
50s
Clippy (beta)
Fit to window
Zoom out
Zoom in

Annotations

71 errors and 55 warnings
no method named `build_ordered_mapping` found for enum `std::option::Option` in the current scope: halo2_proofs/src/dev.rs#L1303
error[E0599]: no method named `build_ordered_mapping` found for enum `std::option::Option` in the current scope --> halo2_proofs/src/dev.rs:1303:28 | 1303 | prover.permutation.build_ordered_mapping(); | ^^^^^^^^^^^^^^^^^^^^^ method not found in `Option<Assembly>` | note: the method `build_ordered_mapping` exists on the type `plonk::permutation::keygen::Assembly` --> halo2_proofs/src/plonk/permutation/keygen.rs:260:5 | 260 | pub fn build_ordered_mapping(&mut self) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `Option::expect` to unwrap the `plonk::permutation::keygen::Assembly` value, panicking if the value is an `Option::None` | 1303 | prover.permutation.expect("REASON").build_ordered_mapping(); | +++++++++++++++++
failed to resolve: use of undeclared type `F`: halo2_proofs/src/dev/graph/layout.rs#L329
error[E0433]: failed to resolve: use of undeclared type `F` --> halo2_proofs/src/dev/graph/layout.rs:329:8 | 329 | Ok(F::ZERO) | ^ | | | use of undeclared type `F` | help: a trait with a similar name exists: `Fn`
failed to resolve: use of undeclared type `F`: halo2_proofs/src/dev/graph/layout.rs#L325
error[E0433]: failed to resolve: use of undeclared type `F` --> halo2_proofs/src/dev/graph/layout.rs:325:8 | 325 | Ok(F::ZERO) | ^ | | | use of undeclared type `F` | help: a trait with a similar name exists: `Fn`
cannot find type `Error` in this scope: halo2_proofs/src/dev/graph/layout.rs#L328
error[E0412]: cannot find type `Error` in this scope --> halo2_proofs/src/dev/graph/layout.rs:328:73 | 328 | fn query_fixed(&self, _column: Column<Fixed>, _row: usize) -> Result<F, Error> { | ^^^^^ not found in this scope | help: consider importing one of these items | 1 + use ark_std::error::Error; | 1 + use ark_std::fmt::Error; | 1 + use ark_std::io::Error; | 1 + use core::error::Error; | and 7 other candidates
cannot find type `F` in this scope: halo2_proofs/src/dev/graph/layout.rs#L328
error[E0412]: cannot find type `F` in this scope --> halo2_proofs/src/dev/graph/layout.rs:328:70 | 328 | fn query_fixed(&self, _column: Column<Fixed>, _row: usize) -> Result<F, Error> { | ^ --> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/ops/function.rs:76:1 | = note: similarly named trait `Fn` defined here | help: a trait with a similar name exists | 328 | fn query_fixed(&self, _column: Column<Fixed>, _row: usize) -> Result<Fn, Error> { | ~~ help: you might be missing a type parameter | 328 | fn query_fixed<F>(&self, _column: Column<Fixed>, _row: usize) -> Result<F, Error> { | +++
cannot find type `Fixed` in this scope: halo2_proofs/src/dev/graph/layout.rs#L328
error[E0412]: cannot find type `Fixed` in this scope --> halo2_proofs/src/dev/graph/layout.rs:328:39 | 328 | fn query_fixed(&self, _column: Column<Fixed>, _row: usize) -> Result<F, Error> { | ^^^^^ not found in this scope | help: consider importing this struct through its public re-export | 1 + use crate::dev::Fixed; |
cannot find type `Error` in this scope: halo2_proofs/src/dev/graph/layout.rs#L324
error[E0412]: cannot find type `Error` in this scope --> halo2_proofs/src/dev/graph/layout.rs:324:75 | 324 | fn query_advice(&self, _column: Column<Advice>, _row: usize) -> Result<F, Error> { | ^^^^^ not found in this scope | help: consider importing one of these items | 1 + use ark_std::error::Error; | 1 + use ark_std::fmt::Error; | 1 + use ark_std::io::Error; | 1 + use core::error::Error; | and 7 other candidates
cannot find type `F` in this scope: halo2_proofs/src/dev/graph/layout.rs#L324
error[E0412]: cannot find type `F` in this scope --> halo2_proofs/src/dev/graph/layout.rs:324:72 | 324 | fn query_advice(&self, _column: Column<Advice>, _row: usize) -> Result<F, Error> { | ^ --> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/ops/function.rs:76:1 | = note: similarly named trait `Fn` defined here | help: a trait with a similar name exists | 324 | fn query_advice(&self, _column: Column<Advice>, _row: usize) -> Result<Fn, Error> { | ~~ help: you might be missing a type parameter | 324 | fn query_advice<F>(&self, _column: Column<Advice>, _row: usize) -> Result<F, Error> { | +++
cannot find type `Advice` in this scope: halo2_proofs/src/dev/graph/layout.rs#L324
error[E0412]: cannot find type `Advice` in this scope --> halo2_proofs/src/dev/graph/layout.rs:324:40 | 324 | fn query_advice(&self, _column: Column<Advice>, _row: usize) -> Result<F, Error> { | ^^^^^^ not found in this scope | help: consider importing this struct through its public re-export | 1 + use crate::dev::Advice; |
the name `Group` is defined multiple times: halo2_proofs/src/dev.rs#L29
error[E0252]: the name `Group` is defined multiple times --> halo2_proofs/src/dev.rs:29:5 | 13 | use group::Group; | ------------ previous import of the trait `Group` here ... 29 | use group::Group; | ^^^^^^^^^^^^ `Group` reimported here | = note: `Group` must be defined only once in the type namespace of this module
Clippy (beta)
Clippy had exited with the 101 exit code
unused import: `PrimeField`: halo2_proofs/src/poly/domain.rs#L12
error: unused import: `PrimeField` --> halo2_proofs/src/poly/domain.rs:12:30 | 12 | ff::{BatchInvert, Field, PrimeField}, | ^^^^^^^^^^
unused import: `Group`: halo2_proofs/src/poly/commitment.rs#L9
error: unused import: `Group` --> halo2_proofs/src/poly/commitment.rs:9:20 | 9 | use group::{Curve, Group}; | ^^^^^
unused import: `BitViewSized`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L18
error: unused import: `BitViewSized` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:18:10 | 18 | use ff::{BitViewSized, PrimeField, PrimeFieldBits, WithSmallOrderMulGroup}; | ^^^^^^^^^^^^
unused import: `rayon::prelude::ParallelIterator`: halo2_proofs/src/plonk/evaluation.rs#L12
error: unused import: `rayon::prelude::ParallelIterator` --> halo2_proofs/src/plonk/evaluation.rs:12:5 | 12 | use rayon::prelude::ParallelIterator; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::hash::Hasher`: halo2_proofs/src/plonk/circuit.rs#L15
error: unused import: `std::hash::Hasher` --> halo2_proofs/src/plonk/circuit.rs:15:5 | 15 | use std::hash::Hasher; | ^^^^^^^^^^^^^^^^^
no method named `build_ordered_mapping` found for enum `std::option::Option` in the current scope: halo2_proofs/src/dev.rs#L1303
error[E0599]: no method named `build_ordered_mapping` found for enum `std::option::Option` in the current scope --> halo2_proofs/src/dev.rs:1303:28 | 1303 | prover.permutation.build_ordered_mapping(); | ^^^^^^^^^^^^^^^^^^^^^ method not found in `Option<Assembly>` | note: the method `build_ordered_mapping` exists on the type `plonk::permutation::keygen::Assembly` --> halo2_proofs/src/plonk/permutation/keygen.rs:260:5 | 260 | pub fn build_ordered_mapping(&mut self) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `Option::expect` to unwrap the `plonk::permutation::keygen::Assembly` value, panicking if the value is an `Option::None` | 1303 | prover.permutation.expect("REASON").build_ordered_mapping(); | +++++++++++++++++
failed to resolve: use of undeclared type `F`: halo2_proofs/src/dev/graph/layout.rs#L329
error[E0433]: failed to resolve: use of undeclared type `F` --> halo2_proofs/src/dev/graph/layout.rs:329:8 | 329 | Ok(F::ZERO) | ^ | | | use of undeclared type `F` | help: a trait with a similar name exists: `Fn`
failed to resolve: use of undeclared type `F`: halo2_proofs/src/dev/graph/layout.rs#L325
error[E0433]: failed to resolve: use of undeclared type `F` --> halo2_proofs/src/dev/graph/layout.rs:325:8 | 325 | Ok(F::ZERO) | ^ | | | use of undeclared type `F` | help: a trait with a similar name exists: `Fn`
unused import: `ff::Field`: halo2_proofs/src/helpers.rs#L3
error: unused import: `ff::Field` --> halo2_proofs/src/helpers.rs:3:5 | 3 | use ff::Field; | ^^^^^^^^^
unused import: `group::Group`: halo2_proofs/src/dev.rs#L29
error: unused import: `group::Group` --> halo2_proofs/src/dev.rs:29:5 | 29 | use group::Group; | ^^^^^^^^^^^^
unused import: `group::Group`: halo2_proofs/src/dev.rs#L13
error: unused import: `group::Group` --> halo2_proofs/src/dev.rs:13:5 | 13 | use group::Group; | ^^^^^^^^^^^^
unused import: `std::time::Instant`: halo2_proofs/src/dev.rs#L8
error: unused import: `std::time::Instant` --> halo2_proofs/src/dev.rs:8:5 | 8 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused imports: `CurveAffine`, `eval_polynomial`, `lagrange_interpolate`: halo2_proofs/src/poly/kzg/multiopen/gwc/verifier.rs#L4
error: unused imports: `CurveAffine`, `eval_polynomial`, `lagrange_interpolate` --> halo2_proofs/src/poly/kzg/multiopen/gwc/verifier.rs:4:25 | 4 | use crate::arithmetic::{eval_polynomial, lagrange_interpolate, powers, CurveAffine}; | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^
unused import: `Field`: halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs#L11
error: unused import: `Field` --> halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs:11:10 | 11 | use ff::{Field, PrimeField}; | ^^^^^
unused imports: `CurveAffine`, `eval_polynomial`: halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs#L2
error: unused imports: `CurveAffine`, `eval_polynomial` --> halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs:2:25 | 2 | use crate::arithmetic::{eval_polynomial, kate_division, powers, CurveAffine}; | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^
unused import: `arithmetic::CurveAffine`: halo2_proofs/src/poly/ipa/multiopen.rs#L7
error: unused import: `arithmetic::CurveAffine` --> halo2_proofs/src/poly/ipa/multiopen.rs:7:13 | 7 | use crate::{arithmetic::CurveAffine, poly::query::Query, transcript::ChallengeScalar}; | ^^^^^^^^^^^^^^^^^^^^^^^
unused import: `Group`: halo2_proofs/src/poly/domain.rs#L13
error: unused import: `Group` --> halo2_proofs/src/poly/domain.rs:13:5 | 13 | Group, | ^^^^^
unused import: `CurveExt`: halo2_proofs/src/poly/commitment.rs#L10
error: unused import: `CurveExt` --> halo2_proofs/src/poly/commitment.rs:10:32 | 10 | use halo2curves::{CurveAffine, CurveExt}; | ^^^^^^^^
unused import: `Curve`: halo2_proofs/src/poly/commitment.rs#L9
error: unused import: `Curve` --> halo2_proofs/src/poly/commitment.rs:9:13 | 9 | use group::{Curve, Group}; | ^^^^^
unused import: `CurveAffine`: halo2_proofs/src/plonk/verifier.rs#L9
error: unused import: `CurveAffine` --> halo2_proofs/src/plonk/verifier.rs:9:48 | 9 | use crate::arithmetic::{compute_inner_product, CurveAffine}; | ^^^^^^^^^^^
unused import: `PrimeField`: halo2_proofs/src/plonk/prover.rs#L1
error: unused import: `PrimeField` --> halo2_proofs/src/plonk/prover.rs:1:35 | 1 | use ff::{Field, FromUniformBytes, PrimeField, WithSmallOrderMulGroup}; | ^^^^^^^^^^
unused import: `collections::HashMap`: halo2_proofs/src/plonk/vanishing/prover.rs#L1
error: unused import: `collections::HashMap` --> halo2_proofs/src/plonk/vanishing/prover.rs:1:11 | 1 | use std::{collections::HashMap, iter}; | ^^^^^^^^^^^^^^^^^^^^
unused import: `ChallengeGamma`: halo2_proofs/src/plonk/mv_lookup/verifier.rs#L4
error: unused import: `ChallengeGamma` --> halo2_proofs/src/plonk/mv_lookup/verifier.rs:4:41 | 4 | circuit::Expression, ChallengeBeta, ChallengeGamma, ChallengeTheta, ChallengeX, | ^^^^^^^^^^^^^^
unused import: `std::time::Instant`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L487
error: unused import: `std::time::Instant` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:487:9 | 487 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused import: `std::collections::BTreeMap`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L486
error: unused import: `std::collections::BTreeMap` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:486:9 | 486 | use std::collections::BTreeMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `halo2curves::bn256::Fr`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L485
error: unused import: `halo2curves::bn256::Fr` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:485:9 | 485 | use halo2curves::bn256::Fr; | ^^^^^^^^^^^^^^^^^^^^^^
unused import: `ff::Field`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L484
error: unused import: `ff::Field` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:484:9 | 484 | use ff::Field; | ^^^^^^^^^
unused import: `ark_std::rand::thread_rng`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L483
error: unused import: `ark_std::rand::thread_rng` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:483:9 | 483 | use ark_std::rand::thread_rng; | ^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::sync::RwLock`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L137
error: unused import: `std::sync::RwLock` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:137:17 | 137 | use std::sync::RwLock; | ^^^^^^^^^^^^^^^^^
unused import: `parallelize_internal`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L34
error: unused import: `parallelize_internal` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:34:37 | 34 | use crate::arithmetic::{par_invert, parallelize_internal}; | ^^^^^^^^^^^^^^^^^^^^
unused import: `collections::BTreeMap`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L29
error: unused import: `collections::BTreeMap` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:29:5 | 29 | collections::BTreeMap, | ^^^^^^^^^^^^^^^^^^^^^
unused imports: `any::TypeId`, `convert::TryInto`, `num::ParseIntError`, `ops::Index`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L27
error: unused imports: `any::TypeId`, `convert::TryInto`, `num::ParseIntError`, `ops::Index` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:27:11 | 27 | use std::{any::TypeId, convert::TryInto, num::ParseIntError, ops::Index}; | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^
unused import: `std::time::Instant`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L26
error: unused import: `std::time::Instant` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:26:5 | 26 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused imports: `BTreeSet`, `HashSet`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L25
error: unused imports: `BTreeSet`, `HashSet` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:25:24 | 25 | use std::collections::{BTreeSet, HashSet}; | ^^^^^^^^ ^^^^^^^
unused import: `rayon::current_num_threads`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L24
error: unused import: `rayon::current_num_threads` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:24:5 | 24 | use rayon::current_num_threads; | ^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `BatchInvert`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L20
error: unused import: `BatchInvert` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:20:10 | 20 | ff::{BatchInvert, Field}, | ^^^^^^^^^^^
unused import: `PrimeFieldBits`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L18
error: unused import: `PrimeFieldBits` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:18:36 | 18 | use ff::{BitViewSized, PrimeField, PrimeFieldBits, WithSmallOrderMulGroup}; | ^^^^^^^^^^^^^^
unused import: `blake2b_simd::Hash`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L17
error: unused import: `blake2b_simd::Hash` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:17:5 | 17 | use blake2b_simd::Hash; | ^^^^^^^^^^^^^^^^^^
unused import: `ExtendedLagrangeCoeff`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L11
error: unused import: `ExtendedLagrangeCoeff` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:11:34 | 11 | Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff, Polynomial, ProverQuery, | ^^^^^^^^^^^^^^^^^^^^^
unused import: `ChallengeGamma`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L2
error: unused import: `ChallengeGamma` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:2:41 | 2 | circuit::Expression, ChallengeBeta, ChallengeGamma, ChallengeTheta, ChallengeX, Error, | ^^^^^^^^^^^^^^
unused import: `std::sync::atomic::fence`: halo2_proofs/src/plonk/evaluation.rs#L14
error: unused import: `std::sync::atomic::fence` --> halo2_proofs/src/plonk/evaluation.rs:14:5 | 14 | use std::sync::atomic::fence; | ^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::process::exit`: halo2_proofs/src/plonk/evaluation.rs#L13
error: unused import: `std::process::exit` --> halo2_proofs/src/plonk/evaluation.rs:13:5 | 13 | use std::process::exit; | ^^^^^^^^^^^^^^^^^^
unused import: `rayon::prelude::IntoParallelIterator`: halo2_proofs/src/plonk/evaluation.rs#L11
error: unused import: `rayon::prelude::IntoParallelIterator` --> halo2_proofs/src/plonk/evaluation.rs:11:5 | 11 | use rayon::prelude::IntoParallelIterator; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `BatchInvert`: halo2_proofs/src/plonk/evaluation.rs#L10
error: unused import: `BatchInvert` --> halo2_proofs/src/plonk/evaluation.rs:10:17 | 10 | use group::ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup}; | ^^^^^^^^^^^
unused import: `eval_polynomial`: halo2_proofs/src/plonk/evaluation.rs#L7
error: unused import: `eval_polynomial` --> halo2_proofs/src/plonk/evaluation.rs:7:18 | 7 | arithmetic::{eval_polynomial, parallelize, CurveAffine}, | ^^^^^^^^^^^^^^^
unused imports: `AdviceQuery`, `FixedQuery`, `InstanceQuery`: halo2_proofs/src/plonk/evaluation.rs#L3
error: unused imports: `AdviceQuery`, `FixedQuery`, `InstanceQuery` --> halo2_proofs/src/plonk/evaluation.rs:3:29 | 3 | mv_lookup, permutation, AdviceQuery, Any, FixedQuery, InstanceQuery, ProvingKey, | ^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^
unused import: `std::marker::PhantomData`: halo2_proofs/src/plonk/circuit.rs#L17
error: unused import: `std::marker::PhantomData` --> halo2_proofs/src/plonk/circuit.rs:17:5 | 17 | use std::marker::PhantomData; | ^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `HashMap`: halo2_proofs/src/plonk/circuit.rs#L12
error: unused import: `HashMap` --> halo2_proofs/src/plonk/circuit.rs:12:34 | 12 | use std::collections::{BTreeMap, HashMap}; | ^^^^^^^
unused import: `multicore`: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L21
error: unused import: `multicore` --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:21:5 | 21 | multicore, | ^^^^^^^^^
unused imports: `Arc`, `Mutex`: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L6
error: unused imports: `Arc`, `Mutex` --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:6:17 | 6 | use std::sync::{Arc, Mutex}; | ^^^ ^^^^^
unused import: `std::ops::Range`: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L5
error: unused import: `std::ops::Range` --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:5:5 | 5 | use std::ops::Range; | ^^^^^^^^^^^^^^^
unnecessary parentheses around index expression: halo2_proofs/src/arithmetic.rs#L306
error: unnecessary parentheses around index expression --> halo2_proofs/src/arithmetic.rs:306:42 | 306 | t1[bitreverse(i, log_split)] = a[(i * sub_n + sub_fft_offset)]; | ^ ^ | = note: `-D unused-parens` implied by `-D warnings` help: remove these parentheses | 306 - t1[bitreverse(i, log_split)] = a[(i * sub_n + sub_fft_offset)]; 306 + t1[bitreverse(i, log_split)] = a[i * sub_n + sub_fft_offset]; |
unused `#[macro_use]` import: halo2_proofs/src/lib.rs#L13
error: unused `#[macro_use]` import --> halo2_proofs/src/lib.rs:13:1 | 13 | #[macro_use] | ^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`
cannot find type `Error` in this scope: halo2_proofs/src/dev/graph/layout.rs#L328
error[E0412]: cannot find type `Error` in this scope --> halo2_proofs/src/dev/graph/layout.rs:328:73 | 328 | fn query_fixed(&self, _column: Column<Fixed>, _row: usize) -> Result<F, Error> { | ^^^^^ not found in this scope | help: consider importing one of these items | 1 + use ark_std::error::Error; | 1 + use ark_std::fmt::Error; | 1 + use ark_std::io::Error; | 1 + use core::error::Error; | and 7 other candidates
cannot find type `F` in this scope: halo2_proofs/src/dev/graph/layout.rs#L328
error[E0412]: cannot find type `F` in this scope --> halo2_proofs/src/dev/graph/layout.rs:328:70 | 328 | fn query_fixed(&self, _column: Column<Fixed>, _row: usize) -> Result<F, Error> { | ^ --> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/ops/function.rs:76:1 | = note: similarly named trait `Fn` defined here | help: a trait with a similar name exists | 328 | fn query_fixed(&self, _column: Column<Fixed>, _row: usize) -> Result<Fn, Error> { | ~~ help: you might be missing a type parameter | 328 | fn query_fixed<F>(&self, _column: Column<Fixed>, _row: usize) -> Result<F, Error> { | +++
cannot find type `Fixed` in this scope: halo2_proofs/src/dev/graph/layout.rs#L328
error[E0412]: cannot find type `Fixed` in this scope --> halo2_proofs/src/dev/graph/layout.rs:328:39 | 328 | fn query_fixed(&self, _column: Column<Fixed>, _row: usize) -> Result<F, Error> { | ^^^^^ not found in this scope | help: consider importing this struct through its public re-export | 1 + use crate::dev::Fixed; |
cannot find type `Error` in this scope: halo2_proofs/src/dev/graph/layout.rs#L324
error[E0412]: cannot find type `Error` in this scope --> halo2_proofs/src/dev/graph/layout.rs:324:75 | 324 | fn query_advice(&self, _column: Column<Advice>, _row: usize) -> Result<F, Error> { | ^^^^^ not found in this scope | help: consider importing one of these items | 1 + use ark_std::error::Error; | 1 + use ark_std::fmt::Error; | 1 + use ark_std::io::Error; | 1 + use core::error::Error; | and 7 other candidates
cannot find type `F` in this scope: halo2_proofs/src/dev/graph/layout.rs#L324
error[E0412]: cannot find type `F` in this scope --> halo2_proofs/src/dev/graph/layout.rs:324:72 | 324 | fn query_advice(&self, _column: Column<Advice>, _row: usize) -> Result<F, Error> { | ^ --> /rustc/a6f8aa5a092c5e46fcbdafe4c80b4e55ba0de41c/library/core/src/ops/function.rs:76:1 | = note: similarly named trait `Fn` defined here | help: a trait with a similar name exists | 324 | fn query_advice(&self, _column: Column<Advice>, _row: usize) -> Result<Fn, Error> { | ~~ help: you might be missing a type parameter | 324 | fn query_advice<F>(&self, _column: Column<Advice>, _row: usize) -> Result<F, Error> { | +++
cannot find type `Advice` in this scope: halo2_proofs/src/dev/graph/layout.rs#L324
error[E0412]: cannot find type `Advice` in this scope --> halo2_proofs/src/dev/graph/layout.rs:324:40 | 324 | fn query_advice(&self, _column: Column<Advice>, _row: usize) -> Result<F, Error> { | ^^^^^^ not found in this scope | help: consider importing this struct through its public re-export | 1 + use crate::dev::Advice; |
the name `Group` is defined multiple times: halo2_proofs/src/dev.rs#L29
error[E0252]: the name `Group` is defined multiple times --> halo2_proofs/src/dev.rs:29:5 | 13 | use group::Group; | ------------ previous import of the trait `Group` here ... 29 | use group::Group; | ^^^^^^^^^^^^ `Group` reimported here | = note: `Group` must be defined only once in the type namespace of this module
unused import: `PrimeField`: halo2_proofs/src/poly/domain.rs#L12
warning: unused import: `PrimeField` --> halo2_proofs/src/poly/domain.rs:12:30 | 12 | ff::{BatchInvert, Field, PrimeField}, | ^^^^^^^^^^
unused import: `Group`: halo2_proofs/src/poly/commitment.rs#L9
warning: unused import: `Group` --> halo2_proofs/src/poly/commitment.rs:9:20 | 9 | use group::{Curve, Group}; | ^^^^^
unused import: `BitViewSized`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L18
warning: unused import: `BitViewSized` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:18:10 | 18 | use ff::{BitViewSized, PrimeField, PrimeFieldBits, WithSmallOrderMulGroup}; | ^^^^^^^^^^^^
unused import: `rayon::prelude::ParallelIterator`: halo2_proofs/src/plonk/evaluation.rs#L12
warning: unused import: `rayon::prelude::ParallelIterator` --> halo2_proofs/src/plonk/evaluation.rs:12:5 | 12 | use rayon::prelude::ParallelIterator; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::hash::Hasher`: halo2_proofs/src/plonk/circuit.rs#L15
warning: unused import: `std::hash::Hasher` --> halo2_proofs/src/plonk/circuit.rs:15:5 | 15 | use std::hash::Hasher; | ^^^^^^^^^^^^^^^^^
unused import: `ff::Field`: halo2_proofs/src/helpers.rs#L3
warning: unused import: `ff::Field` --> halo2_proofs/src/helpers.rs:3:5 | 3 | use ff::Field; | ^^^^^^^^^
unused import: `group::Group`: halo2_proofs/src/dev.rs#L29
warning: unused import: `group::Group` --> halo2_proofs/src/dev.rs:29:5 | 29 | use group::Group; | ^^^^^^^^^^^^
unused import: `group::Group`: halo2_proofs/src/dev.rs#L13
warning: unused import: `group::Group` --> halo2_proofs/src/dev.rs:13:5 | 13 | use group::Group; | ^^^^^^^^^^^^
unused import: `std::time::Instant`: halo2_proofs/src/dev.rs#L8
warning: unused import: `std::time::Instant` --> halo2_proofs/src/dev.rs:8:5 | 8 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused imports: `CurveAffine`, `eval_polynomial`, `lagrange_interpolate`: halo2_proofs/src/poly/kzg/multiopen/gwc/verifier.rs#L4
warning: unused imports: `CurveAffine`, `eval_polynomial`, `lagrange_interpolate` --> halo2_proofs/src/poly/kzg/multiopen/gwc/verifier.rs:4:25 | 4 | use crate::arithmetic::{eval_polynomial, lagrange_interpolate, powers, CurveAffine}; | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^
unused import: `Field`: halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs#L11
warning: unused import: `Field` --> halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs:11:10 | 11 | use ff::{Field, PrimeField}; | ^^^^^
unused imports: `CurveAffine`, `eval_polynomial`: halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs#L2
warning: unused imports: `CurveAffine`, `eval_polynomial` --> halo2_proofs/src/poly/kzg/multiopen/gwc/prover.rs:2:25 | 2 | use crate::arithmetic::{eval_polynomial, kate_division, powers, CurveAffine}; | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^
unused import: `arithmetic::CurveAffine`: halo2_proofs/src/poly/ipa/multiopen.rs#L7
warning: unused import: `arithmetic::CurveAffine` --> halo2_proofs/src/poly/ipa/multiopen.rs:7:13 | 7 | use crate::{arithmetic::CurveAffine, poly::query::Query, transcript::ChallengeScalar}; | ^^^^^^^^^^^^^^^^^^^^^^^
unused import: `Group`: halo2_proofs/src/poly/domain.rs#L13
warning: unused import: `Group` --> halo2_proofs/src/poly/domain.rs:13:5 | 13 | Group, | ^^^^^
unused import: `CurveExt`: halo2_proofs/src/poly/commitment.rs#L10
warning: unused import: `CurveExt` --> halo2_proofs/src/poly/commitment.rs:10:32 | 10 | use halo2curves::{CurveAffine, CurveExt}; | ^^^^^^^^
unused import: `Curve`: halo2_proofs/src/poly/commitment.rs#L9
warning: unused import: `Curve` --> halo2_proofs/src/poly/commitment.rs:9:13 | 9 | use group::{Curve, Group}; | ^^^^^
unused import: `CurveAffine`: halo2_proofs/src/plonk/verifier.rs#L9
warning: unused import: `CurveAffine` --> halo2_proofs/src/plonk/verifier.rs:9:48 | 9 | use crate::arithmetic::{compute_inner_product, CurveAffine}; | ^^^^^^^^^^^
unused import: `PrimeField`: halo2_proofs/src/plonk/prover.rs#L1
warning: unused import: `PrimeField` --> halo2_proofs/src/plonk/prover.rs:1:35 | 1 | use ff::{Field, FromUniformBytes, PrimeField, WithSmallOrderMulGroup}; | ^^^^^^^^^^
unused import: `collections::HashMap`: halo2_proofs/src/plonk/vanishing/prover.rs#L1
warning: unused import: `collections::HashMap` --> halo2_proofs/src/plonk/vanishing/prover.rs:1:11 | 1 | use std::{collections::HashMap, iter}; | ^^^^^^^^^^^^^^^^^^^^
unused import: `ChallengeGamma`: halo2_proofs/src/plonk/mv_lookup/verifier.rs#L4
warning: unused import: `ChallengeGamma` --> halo2_proofs/src/plonk/mv_lookup/verifier.rs:4:41 | 4 | circuit::Expression, ChallengeBeta, ChallengeGamma, ChallengeTheta, ChallengeX, | ^^^^^^^^^^^^^^
unused import: `std::time::Instant`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L487
warning: unused import: `std::time::Instant` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:487:9 | 487 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused import: `std::collections::BTreeMap`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L486
warning: unused import: `std::collections::BTreeMap` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:486:9 | 486 | use std::collections::BTreeMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `halo2curves::bn256::Fr`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L485
warning: unused import: `halo2curves::bn256::Fr` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:485:9 | 485 | use halo2curves::bn256::Fr; | ^^^^^^^^^^^^^^^^^^^^^^
unused import: `ff::Field`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L484
warning: unused import: `ff::Field` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:484:9 | 484 | use ff::Field; | ^^^^^^^^^
unused import: `ark_std::rand::thread_rng`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L483
warning: unused import: `ark_std::rand::thread_rng` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:483:9 | 483 | use ark_std::rand::thread_rng; | ^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::sync::RwLock`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L137
warning: unused import: `std::sync::RwLock` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:137:17 | 137 | use std::sync::RwLock; | ^^^^^^^^^^^^^^^^^
unused import: `parallelize_internal`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L34
warning: unused import: `parallelize_internal` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:34:37 | 34 | use crate::arithmetic::{par_invert, parallelize_internal}; | ^^^^^^^^^^^^^^^^^^^^
unused import: `collections::BTreeMap`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L29
warning: unused import: `collections::BTreeMap` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:29:5 | 29 | collections::BTreeMap, | ^^^^^^^^^^^^^^^^^^^^^
unused imports: `any::TypeId`, `convert::TryInto`, `num::ParseIntError`, `ops::Index`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L27
warning: unused imports: `any::TypeId`, `convert::TryInto`, `num::ParseIntError`, `ops::Index` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:27:11 | 27 | use std::{any::TypeId, convert::TryInto, num::ParseIntError, ops::Index}; | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^
unused import: `std::time::Instant`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L26
warning: unused import: `std::time::Instant` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:26:5 | 26 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused imports: `BTreeSet`, `HashSet`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L25
warning: unused imports: `BTreeSet`, `HashSet` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:25:24 | 25 | use std::collections::{BTreeSet, HashSet}; | ^^^^^^^^ ^^^^^^^
unused import: `rayon::current_num_threads`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L24
warning: unused import: `rayon::current_num_threads` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:24:5 | 24 | use rayon::current_num_threads; | ^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `BatchInvert`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L20
warning: unused import: `BatchInvert` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:20:10 | 20 | ff::{BatchInvert, Field}, | ^^^^^^^^^^^
unused import: `PrimeFieldBits`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L18
warning: unused import: `PrimeFieldBits` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:18:36 | 18 | use ff::{BitViewSized, PrimeField, PrimeFieldBits, WithSmallOrderMulGroup}; | ^^^^^^^^^^^^^^
unused import: `blake2b_simd::Hash`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L17
warning: unused import: `blake2b_simd::Hash` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:17:5 | 17 | use blake2b_simd::Hash; | ^^^^^^^^^^^^^^^^^^
unused import: `ExtendedLagrangeCoeff`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L11
warning: unused import: `ExtendedLagrangeCoeff` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:11:34 | 11 | Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff, Polynomial, ProverQuery, | ^^^^^^^^^^^^^^^^^^^^^
unused import: `ChallengeGamma`: halo2_proofs/src/plonk/mv_lookup/prover.rs#L2
warning: unused import: `ChallengeGamma` --> halo2_proofs/src/plonk/mv_lookup/prover.rs:2:41 | 2 | circuit::Expression, ChallengeBeta, ChallengeGamma, ChallengeTheta, ChallengeX, Error, | ^^^^^^^^^^^^^^
unused import: `std::sync::atomic::fence`: halo2_proofs/src/plonk/evaluation.rs#L14
warning: unused import: `std::sync::atomic::fence` --> halo2_proofs/src/plonk/evaluation.rs:14:5 | 14 | use std::sync::atomic::fence; | ^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::process::exit`: halo2_proofs/src/plonk/evaluation.rs#L13
warning: unused import: `std::process::exit` --> halo2_proofs/src/plonk/evaluation.rs:13:5 | 13 | use std::process::exit; | ^^^^^^^^^^^^^^^^^^
unused import: `rayon::prelude::IntoParallelIterator`: halo2_proofs/src/plonk/evaluation.rs#L11
warning: unused import: `rayon::prelude::IntoParallelIterator` --> halo2_proofs/src/plonk/evaluation.rs:11:5 | 11 | use rayon::prelude::IntoParallelIterator; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `BatchInvert`: halo2_proofs/src/plonk/evaluation.rs#L10
warning: unused import: `BatchInvert` --> halo2_proofs/src/plonk/evaluation.rs:10:17 | 10 | use group::ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup}; | ^^^^^^^^^^^
unused import: `eval_polynomial`: halo2_proofs/src/plonk/evaluation.rs#L7
warning: unused import: `eval_polynomial` --> halo2_proofs/src/plonk/evaluation.rs:7:18 | 7 | arithmetic::{eval_polynomial, parallelize, CurveAffine}, | ^^^^^^^^^^^^^^^
unused imports: `AdviceQuery`, `FixedQuery`, `InstanceQuery`: halo2_proofs/src/plonk/evaluation.rs#L3
warning: unused imports: `AdviceQuery`, `FixedQuery`, `InstanceQuery` --> halo2_proofs/src/plonk/evaluation.rs:3:29 | 3 | mv_lookup, permutation, AdviceQuery, Any, FixedQuery, InstanceQuery, ProvingKey, | ^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^
unused import: `std::marker::PhantomData`: halo2_proofs/src/plonk/circuit.rs#L17
warning: unused import: `std::marker::PhantomData` --> halo2_proofs/src/plonk/circuit.rs:17:5 | 17 | use std::marker::PhantomData; | ^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `HashMap`: halo2_proofs/src/plonk/circuit.rs#L12
warning: unused import: `HashMap` --> halo2_proofs/src/plonk/circuit.rs:12:34 | 12 | use std::collections::{BTreeMap, HashMap}; | ^^^^^^^
unused import: `multicore`: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L21
warning: unused import: `multicore` --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:21:5 | 21 | multicore, | ^^^^^^^^^
unused imports: `Arc`, `Mutex`: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L6
warning: unused imports: `Arc`, `Mutex` --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:6:17 | 6 | use std::sync::{Arc, Mutex}; | ^^^ ^^^^^
unused import: `std::ops::Range`: halo2_proofs/src/circuit/floor_planner/single_pass.rs#L5
warning: unused import: `std::ops::Range` --> halo2_proofs/src/circuit/floor_planner/single_pass.rs:5:5 | 5 | use std::ops::Range; | ^^^^^^^^^^^^^^^
unnecessary parentheses around index expression: halo2_proofs/src/arithmetic.rs#L306
warning: unnecessary parentheses around index expression --> halo2_proofs/src/arithmetic.rs:306:42 | 306 | t1[bitreverse(i, log_split)] = a[(i * sub_n + sub_fft_offset)]; | ^ ^ | = note: `#[warn(unused_parens)]` on by default help: remove these parentheses | 306 - t1[bitreverse(i, log_split)] = a[(i * sub_n + sub_fft_offset)]; 306 + t1[bitreverse(i, log_split)] = a[i * sub_n + sub_fft_offset]; |
unused `#[macro_use]` import: halo2_proofs/src/lib.rs#L13
warning: unused `#[macro_use]` import --> halo2_proofs/src/lib.rs:13:1 | 13 | #[macro_use] | ^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/