Skip to content

upgrade sha256

upgrade sha256 #647

Triggered via push November 29, 2023 14:01
Status Success
Total duration 21s
Artifacts

ci.yml

on: push
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 15 warnings
type annotations needed: halo2_gadgets/benches/sha256.rs#L55
error[E0283]: type annotations needed --> halo2_gadgets/benches/sha256.rs:55:32 | 55 | let table16_chip = Table16Chip::construct(config); | ^^^^^^^^^^^^^^^^^^^^^^ cannot infer type of the type parameter `F` declared on the associated function `construct` | = note: cannot satisfy `_: halo2curves::FieldExt` note: required by a bound in `halo2_gadgets::sha256::Table16Chip::construct` --> /home/runner/work/halo2/halo2/halo2_gadgets/src/sha256/table16.rs:297:25 | 297 | pub fn construct<F: Field>(config: <Self as Chip<F>>::Config) -> Self { | ^^^^^ required by this bound in `halo2_gadgets::sha256::Table16Chip::construct` help: consider specifying the generic argument | 55 | let table16_chip = Table16Chip::construct::<F>(config); | +++++ help: consider specifying the type argument in the function call | 55 | let table16_chip = Table16Chip::construct::<F>(config); | +++++
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L165
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:165:10 | 165 | ) -> Result<Vec<(AssignedBits<F, 16>, AssignedBits<F, 16>)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs#L85
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs:85:10 | 85 | ) -> Result<Vec<(AssignedBits<F, 16>, AssignedBits<F, 16>)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L154
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:154:10 | 154 | ) -> Result< | __________^ 155 | | ( 156 | | AssignedBits<F, 32>, 157 | | (AssignedBits<F, 16>, AssignedBits<F, 16>), 158 | | ), 159 | | Error, 160 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/compression.rs#L432
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/compression.rs:432:10 | 432 | ) -> ( | __________^ 433 | | RoundWordA<F>, 434 | | RoundWord<F>, 435 | | RoundWord<F>, ... | 440 | | RoundWordDense<F>, 441 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L946
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:946:6 | 946 | ) -> ( | ______^ 947 | | RoundWordA<F>, 948 | | RoundWord<F>, 949 | | RoundWord<F>, ... | 954 | | RoundWordDense<F>, 955 | | ) { | |_^ | = note: `-D clippy::type-complexity` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L165
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:165:10 | 165 | ) -> Result<Vec<(AssignedBits<F, 16>, AssignedBits<F, 16>)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs#L85
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs:85:10 | 85 | ) -> Result<Vec<(AssignedBits<F, 16>, AssignedBits<F, 16>)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L154
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:154:10 | 154 | ) -> Result< | __________^ 155 | | ( 156 | | AssignedBits<F, 32>, 157 | | (AssignedBits<F, 16>, AssignedBits<F, 16>), 158 | | ), 159 | | Error, 160 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/compression.rs#L432
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/compression.rs:432:10 | 432 | ) -> ( | __________^ 433 | | RoundWordA<F>, 434 | | RoundWord<F>, 435 | | RoundWord<F>, ... | 440 | | RoundWordDense<F>, 441 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L946
error: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:946:6 | 946 | ) -> ( | ______^ 947 | | RoundWordA<F>, 948 | | RoundWord<F>, 949 | | RoundWord<F>, ... | 954 | | RoundWordDense<F>, 955 | | ) { | |_^ | = note: `-D clippy::type-complexity` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L165
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:165:10 | 165 | ) -> Result<Vec<(AssignedBits<F, 16>, AssignedBits<F, 16>)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs#L85
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs:85:10 | 85 | ) -> Result<Vec<(AssignedBits<F, 16>, AssignedBits<F, 16>)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L154
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:154:10 | 154 | ) -> Result< | __________^ 155 | | ( 156 | | AssignedBits<F, 32>, 157 | | (AssignedBits<F, 16>, AssignedBits<F, 16>), 158 | | ), 159 | | Error, 160 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/compression.rs#L432
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/compression.rs:432:10 | 432 | ) -> ( | __________^ 433 | | RoundWordA<F>, 434 | | RoundWord<F>, 435 | | RoundWord<F>, ... | 440 | | RoundWordDense<F>, 441 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L946
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:946:6 | 946 | ) -> ( | ______^ 947 | | RoundWordA<F>, 948 | | RoundWord<F>, 949 | | RoundWord<F>, ... | 954 | | RoundWordDense<F>, 955 | | ) { | |_^ | = note: `-W clippy::type-complexity` implied by `-W clippy::all` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L165
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:165:10 | 165 | ) -> Result<Vec<(AssignedBits<F, 16>, AssignedBits<F, 16>)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs#L85
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/subregion1.rs:85:10 | 85 | ) -> Result<Vec<(AssignedBits<F, 16>, AssignedBits<F, 16>)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L154
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:154:10 | 154 | ) -> Result< | __________^ 155 | | ( 156 | | AssignedBits<F, 32>, 157 | | (AssignedBits<F, 16>, AssignedBits<F, 16>), 158 | | ), 159 | | Error, 160 | | > { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/compression.rs#L432
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/compression.rs:432:10 | 432 | ) -> ( | __________^ 433 | | RoundWordA<F>, 434 | | RoundWord<F>, 435 | | RoundWord<F>, ... | 440 | | RoundWordDense<F>, 441 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L946
warning: very complex type used. Consider factoring parts into `type` definitions --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:946:6 | 946 | ) -> ( | ______^ 947 | | RoundWordA<F>, 948 | | RoundWord<F>, 949 | | RoundWord<F>, ... | 954 | | RoundWordDense<F>, 955 | | ) { | |_^ | = note: `-W clippy::type-complexity` implied by `-W clippy::all` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity