Skip to content

disable selector compression #511

disable selector compression

disable selector compression #511

Triggered via push July 11, 2023 05:43
Status Success
Total duration 25s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

ci.yml

on: push
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 18 warnings
redundant clone: halo2_proofs/src/plonk.rs#L127
error: redundant clone --> halo2_proofs/src/plonk.rs:127:54 | 127 | let (cs, _) = cs.compress_selectors(selectors.clone()); | ^^^^^^^^ help: remove this | = note: `-D clippy::redundant-clone` implied by `-D warnings` note: this value is dropped without further use --> halo2_proofs/src/plonk.rs:127:45 | 127 | let (cs, _) = cs.compress_selectors(selectors.clone()); | ^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
this boolean expression contains a logic bug: halo2_proofs/src/plonk/circuit/compress_selectors.rs#L75
error: this boolean expression contains a logic bug --> halo2_proofs/src/plonk/circuit/compress_selectors.rs:75:12 | 75 | if true || selector.max_degree == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true` | = note: `#[deny(clippy::logic_bug)]` on by default help: this expression can be optimized out by applying boolean operations to the outer expression --> halo2_proofs/src/plonk/circuit/compress_selectors.rs:75:20 | 75 | if true || selector.max_degree == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
function `unpack` is never used: halo2_proofs/src/helpers.rs#L180
error: function `unpack` is never used --> halo2_proofs/src/helpers.rs:180:8 | 180 | pub fn unpack(byte: u8, bits: &mut [bool]) { | ^^^^^^
function `pack` is never used: halo2_proofs/src/helpers.rs#L170
error: function `pack` is never used --> halo2_proofs/src/helpers.rs:170:8 | 170 | pub fn pack(bits: &[bool]) -> u8 { | ^^^^ | = note: `-D dead-code` implied by `-D warnings`
redundant clone: halo2_proofs/src/plonk.rs#L127
error: redundant clone --> halo2_proofs/src/plonk.rs:127:54 | 127 | let (cs, _) = cs.compress_selectors(selectors.clone()); | ^^^^^^^^ help: remove this | = note: `-D clippy::redundant-clone` implied by `-D warnings` note: this value is dropped without further use --> halo2_proofs/src/plonk.rs:127:45 | 127 | let (cs, _) = cs.compress_selectors(selectors.clone()); | ^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
this boolean expression contains a logic bug: halo2_proofs/src/plonk/circuit/compress_selectors.rs#L75
error: this boolean expression contains a logic bug --> halo2_proofs/src/plonk/circuit/compress_selectors.rs:75:12 | 75 | if true || selector.max_degree == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true` | = note: `#[deny(clippy::logic_bug)]` on by default help: this expression can be optimized out by applying boolean operations to the outer expression --> halo2_proofs/src/plonk/circuit/compress_selectors.rs:75:20 | 75 | if true || selector.max_degree == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
function `unpack` is never used: halo2_proofs/src/helpers.rs#L180
error: function `unpack` is never used --> halo2_proofs/src/helpers.rs:180:8 | 180 | pub fn unpack(byte: u8, bits: &mut [bool]) { | ^^^^^^
function `pack` is never used: halo2_proofs/src/helpers.rs#L170
error: function `pack` is never used --> halo2_proofs/src/helpers.rs:170:8 | 170 | pub fn pack(bits: &[bool]) -> u8 { | ^^^^ | = note: `-D dead-code` implied by `-D warnings`
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cannot test inner items: halo2_proofs/tests/plonk_api.rs#L674
warning: cannot test inner items --> halo2_proofs/tests/plonk_api.rs:674:5 | 674 | #[test] | ^^^^^^^ | = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
cannot test inner items: halo2_proofs/tests/plonk_api.rs#L644
warning: cannot test inner items --> halo2_proofs/tests/plonk_api.rs:644:5 | 644 | #[test] | ^^^^^^^ | = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
cannot test inner items: halo2_proofs/tests/plonk_api.rs#L599
warning: cannot test inner items --> halo2_proofs/tests/plonk_api.rs:599:5 | 599 | #[test] | ^^^^^^^ | = note: `#[warn(unnameable_test_items)]` on by default = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
redundant clone: halo2_proofs/tests/plonk_api.rs#L558
warning: redundant clone --> halo2_proofs/tests/plonk_api.rs:558:39 | 558 | &[circuit.clone(), circuit.clone()], | ^^^^^^^^ help: remove this | = note: `-W clippy::redundant-clone` implied by `-W clippy::all` note: this value is dropped without further use --> halo2_proofs/tests/plonk_api.rs:558:32 | 558 | &[circuit.clone(), circuit.clone()], | ^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
function `test_plonk_api_ipa` is never used: halo2_proofs/tests/plonk_api.rs#L675
warning: function `test_plonk_api_ipa` is never used --> halo2_proofs/tests/plonk_api.rs:675:8 | 675 | fn test_plonk_api_ipa() { | ^^^^^^^^^^^^^^^^^^
function `test_plonk_api_shplonk` is never used: halo2_proofs/tests/plonk_api.rs#L645
warning: function `test_plonk_api_shplonk` is never used --> halo2_proofs/tests/plonk_api.rs:645:8 | 645 | fn test_plonk_api_shplonk() { | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
redundant clone: halo2_proofs/src/plonk.rs#L127
warning: redundant clone --> halo2_proofs/src/plonk.rs:127:54 | 127 | let (cs, _) = cs.compress_selectors(selectors.clone()); | ^^^^^^^^ help: remove this | = note: `-W clippy::redundant-clone` implied by `-W clippy::all` note: this value is dropped without further use --> halo2_proofs/src/plonk.rs:127:45 | 127 | let (cs, _) = cs.compress_selectors(selectors.clone()); | ^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
this boolean expression contains a logic bug: halo2_proofs/src/plonk/circuit/compress_selectors.rs#L75
warning: this boolean expression contains a logic bug --> halo2_proofs/src/plonk/circuit/compress_selectors.rs:75:12 | 75 | if true || selector.max_degree == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true` | = note: `-W clippy::logic-bug` implied by `-W clippy::all` help: this expression can be optimized out by applying boolean operations to the outer expression --> halo2_proofs/src/plonk/circuit/compress_selectors.rs:75:20 | 75 | if true || selector.max_degree == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
function `unpack` is never used: halo2_proofs/src/helpers.rs#L180
warning: function `unpack` is never used --> halo2_proofs/src/helpers.rs:180:8 | 180 | pub fn unpack(byte: u8, bits: &mut [bool]) { | ^^^^^^
function `pack` is never used: halo2_proofs/src/helpers.rs#L170
warning: function `pack` is never used --> halo2_proofs/src/helpers.rs:170:8 | 170 | pub fn pack(bits: &[bool]) -> u8 { | ^^^^ | = note: `#[warn(dead_code)]` on by default
redundant clone: halo2_proofs/src/plonk.rs#L127
warning: redundant clone --> halo2_proofs/src/plonk.rs:127:54 | 127 | let (cs, _) = cs.compress_selectors(selectors.clone()); | ^^^^^^^^ help: remove this | = note: `-W clippy::redundant-clone` implied by `-W clippy::all` note: this value is dropped without further use --> halo2_proofs/src/plonk.rs:127:45 | 127 | let (cs, _) = cs.compress_selectors(selectors.clone()); | ^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
this boolean expression contains a logic bug: halo2_proofs/src/plonk/circuit/compress_selectors.rs#L75
warning: this boolean expression contains a logic bug --> halo2_proofs/src/plonk/circuit/compress_selectors.rs:75:12 | 75 | if true || selector.max_degree == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true` | = note: `-W clippy::logic-bug` implied by `-W clippy::all` help: this expression can be optimized out by applying boolean operations to the outer expression --> halo2_proofs/src/plonk/circuit/compress_selectors.rs:75:20 | 75 | if true || selector.max_degree == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
function `unpack` is never used: halo2_proofs/src/helpers.rs#L180
warning: function `unpack` is never used --> halo2_proofs/src/helpers.rs:180:8 | 180 | pub fn unpack(byte: u8, bits: &mut [bool]) { | ^^^^^^
function `pack` is never used: halo2_proofs/src/helpers.rs#L170
warning: function `pack` is never used --> halo2_proofs/src/helpers.rs:170:8 | 170 | pub fn pack(bits: &[bool]) -> u8 { | ^^^^ | = note: `#[warn(dead_code)]` on by default