-
Notifications
You must be signed in to change notification settings - Fork 281
feat: reject txs with max l1 data fee in worker #1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThis update introduces a new validation step in the transaction processing workflow of the miner's worker, ensuring transactions with excessive L1 data fees are rejected. Additionally, the patch version in the version constants is incremented from 55 to 56. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Worker
participant Fees
User->>Worker: Submit Transaction
Worker->>Worker: Validate size and block size
Worker->>Fees: CalculateL1DataFee(tx, state, config, blockNum)
Fees-->>Worker: Return L1 data fee or error
alt Fee calculation error
Worker-->>User: Reject transaction (error)
else Fee >= MaxL1DataFee
Worker-->>User: Reject transaction (invalid L1 data fee)
else Fee < MaxL1DataFee
Worker->>Worker: Continue with transaction execution
end
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
miner/scroll_worker.go
(1 hunks)params/version.go
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: check
- GitHub Check: test
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
params/version.go (1)
24-29
: Patch bump looks goodThe version patch is incremented from 55 → 56 in line 27 to reflect the new feature. No further action required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
1. Purpose or design rationale of this PR
Reject txs with overly large data fee in worker.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?Summary by CodeRabbit
New Features
Chores