Feat: combine multiple loops into one in sumcheck verifier #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We merge three loops into one:
observe_then_sample
: observe the prover messages and then samplecheck_and_generate_subclaim
: computecheck_and_generate_subclaim
: assert thatNote that the above three loops need to load prover message array by three times. And each load takes at least 7 cycles.
It's easy to see that we can merge them into one loop.
Performance
Cycle distribution