Skip to content

Feat: extend array rt by rt_merge #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Feat: extend array rt by rt_merge #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions src/arithmetics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,29 +238,21 @@ pub fn sum<C: Config>(
acc
}

// Join two arrays
pub fn join<C: Config>(
// Extend an array by one element
pub fn extend<C: Config>(
builder: &mut Builder<C>,
a: &Array<C, Ext<C::F, C::EF>>,
b: &Array<C, Ext<C::F, C::EF>>,
arr: &Array<C, Ext<C::F, C::EF>>,
elem: &Ext<C::F, C::EF>,
) -> Array<C, Ext<C::F, C::EF>> {
let a_len = a.len();
let b_len = b.len();
let out_len = builder.eval_expr(a_len.clone() + b_len.clone());
let out = builder.dyn_array(out_len);
let new_len: Var<C::N> = builder.eval(arr.len() + C::N::ONE);
let out = builder.dyn_array(new_len);

builder.range(0, a_len.clone()).for_each(|i_vec, builder| {
builder.range(0, arr.len()).for_each(|i_vec, builder| {
let i = i_vec[0];
let a_val = builder.get(a, i);
builder.set(&out, i, a_val);
});

builder.range(0, b_len).for_each(|i_vec, builder| {
let b_i = i_vec[0];
let i = builder.eval_expr(b_i + a_len.clone());
let b_val = builder.get(b, b_i);
builder.set(&out, i, b_val);
let val = builder.get(arr, i);
builder.set_value(&out, i, val);
});
builder.set_value(&out, arr.len(), elem.clone());

out
}
Expand Down
7 changes: 3 additions & 4 deletions src/tower_verifier/program.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ use super::binding::{
IOPProverMessageVariable, PointAndEvalVariable, PointVariable, TowerVerifierInputVariable,
};
use crate::arithmetics::{
challenger_multi_observe, dot_product, dot_product_pt_n_eval, eq_eval, evaluate_at_point, exts_to_felts, fixed_dot_product, gen_alpha_pows, is_smaller_than, join, product, reverse
challenger_multi_observe, dot_product, dot_product_pt_n_eval, eq_eval, evaluate_at_point,
extend, exts_to_felts, fixed_dot_product, gen_alpha_pows, is_smaller_than, product, reverse,
};
use crate::transcript::transcript_observe_label;
use openvm_native_compiler::prelude::*;
Expand Down Expand Up @@ -444,9 +445,7 @@ pub fn verify_tower_proof<C: Config>(
let c2: Ext<<C as Config>::F, <C as Config>::EF> = builder.eval(r_merge.clone());
let coeffs = vec![c1, c2];

let r_merge_arr = builder.dyn_array(RVar::from(1));
builder.set(&r_merge_arr, 0, r_merge);
let rt_prime = join(builder, &sub_rt, &r_merge_arr);
let rt_prime = extend(builder, &sub_rt, &r_merge);
builder.cycle_tracker_end("derive rt_prime");

// generate next round challenge
Expand Down