feat: dot product when one vector's size is known #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kunxian-xia
added a commit
that referenced
this pull request
Jun 19, 2025
* Test sample vm instruction programs * Articulate idx workflow * Articulate idx workflow * Change dependencies * Complete builder constraint based multi observe * Keep new builder fn * Establish entry point * Use opcode * Switch remote dependency * Remove array enumeration * Remove debug flags * Fix consistency test * add cycle count unit test for sumcheck verifier * enable new sample_ext implementation * improve * cycle profiling * update ceno dependency * remove unused interpolate_uni_poly and add tower verifier unit test * set num product specs to 2 * dot product whenone vector's size is known (#17) * replace join by extend (#18) * Feat: compute powers of `alpha` on the fly (#19) * compute alpha's powers on the fly * chore * cleanup * Feat: compute `is_smaller_than` incrementally (#20) * compute is_smaller_than incrementally * is_smaller_than for logup spec * multiply by eq_e later * Finish replacing iterative smaller_than * Remove import * remove next_layer_skip array * update point and eval only for last layer --------- Co-authored-by: Ray Gao <[email protected]> * fix merge error * track cycles in sumcheck verifier * Feat: combine multiple loops into one in sumcheck verifier (#22) * combine two phases into one to reduce memory rw cost * save 3 cycles by using 0+0 trick * div instead of *x.inverse() (#23) * remove low-level cycle trackers * turn on tracing for e2e test --------- Co-authored-by: Ray Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Since number of elements in
coeffs = vec![1-r_merge, r_merge]is known at the setup time, we don't need to useArrayto store it.Performance
This PR saves about 20 cycles.