Skip to content

Conversation

@priyankaforu
Copy link
Contributor

Contributor checklist


Added The Missing Command Variables And Translation Prompts in the Norwegian keyboard layout

@andrewtavis please review it and lemme know the feedback

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CI unit test workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 21, 2025 00:35
"u": uAlternateKeys,
"ä": äAlternateKeys,
"ö": öAlternateKeys,
"å": åAlternateKeys,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for expanding these out, @priyankaforu!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks so much for the great research and contribution here, @priyankaforu! You were right to remove some of the comments from the interface variable file that were around the key assignments. Really not needed to have those, and I've done it in the other files as well now 😊

Would you have interest in doing the same for #133? :) Feel free to write in there and I'll assign so you can work on it! You can get started right away if so.

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 21, 2025
@andrewtavis andrewtavis merged commit 4ea2b5c into scribe-org:main Oct 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted as a part of Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants