-
Notifications
You must be signed in to change notification settings - Fork 97
Task: Updated NBInterface and Command Variables #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: Updated NBInterface and Command Variables #549
The head ref may contain hidden characters: "feature/Add-Bokm\u00E5l-(Norwegian)-keyboard-#135"
Conversation
Thank you for the pull request! ❤️The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
| "u": uAlternateKeys, | ||
| "ä": äAlternateKeys, | ||
| "ö": öAlternateKeys, | ||
| "å": åAlternateKeys, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks for expanding these out, @priyankaforu!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks so much for the great research and contribution here, @priyankaforu! You were right to remove some of the comments from the interface variable file that were around the key assignments. Really not needed to have those, and I've done it in the other files as well now 😊
Would you have interest in doing the same for #133? :) Feel free to write in there and I'll assign so you can work on it! You can get started right away if so.
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideAdded The Missing Command Variables And Translation Prompts in the Norwegian keyboard layout
@andrewtavis please review it and lemme know the feedback