-
Notifications
You must be signed in to change notification settings - Fork 95
[#540] Fix caps locked capitalisation not taken into account #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#540] Fix caps locked capitalisation not taken into account #547
Conversation
Thank you for the pull request! ❤️The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
55264bf to
d761498
Compare
d761498 to
7e9b0c3
Compare
|
Thanks so much for the PR, @damien-rivet! Always wonderful to work with you :) We'll try to get to the review in the coming days! |
|
Thanks 🫶 I just need to figure out why the CI is acting weird but apart from that it should be a smooth review. |
|
@andrewtavis I did some local testing and the issue is that the CI script for PRs is attempting to run the tests on the latest OS version available on the simulator. Which results in using OS26 (which should be fine) but for an unknown reason, the simulator hangs and stays black, forcing the CI run to time out. I've update the GHA file to force the OS to 18.5 and it solves the issue completely. I've also added |
|
@andrewtavis I suspect there are quite a lot of things that can be done to improve the CI build times (simplify the xcode projects, etc.) and the GHA workflow itself (build followed by a test build is redundant for exemple and takes twice as much time). But this can be done later on. |
| ### 🐞 Bug Fixes | ||
|
|
||
| - The tab bar titles are now localized for the application ([#517](https://github.com/scribe-org/Scribe-iOS/issues/517)). | ||
| - Using capslock would always output the lowercase version of the tapped character ([#540](https://github.com/scribe-org/Scribe-iOS/issues/540)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Really appreciate the edit to the changelog, @damien-rivet!
| } | ||
| if shiftButtonState == .shift { | ||
|
|
||
| switch shiftButtonState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks as well for doing these edits to add more switch cases to the code base in sensible places :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing and the functionality is exactly what we're looking for 😊 Always great to get contributions from you, @damien-rivet! Perfect timing as the changes for pr_ci.yaml will be integrated into other PRs that will make it easier on the Outreachy applicants we have in the community to contribute 😊
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
When using the CapsLock shift button, the uppercase characters were not displayed correctly AND when tapping on them, they would always output the lowercase version of them.
A long time ago, during another contribution, I noticed that we were using 2 separate enums to handle the state of both the shift & capslock buttons, leading to complex conditions blocks throughout the code.
In this PR, I reconcile them under a single enum & single app property to simplify the management of those buttons.
This allowed me to fix both issue with a single stone.
Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-10-13.at.09.29.21.mp4
Related issue