Skip to content

Conversation

@catreedle
Copy link
Contributor

Contributor checklist


Description

This PR is for adding a new keyboard for the Indonesian language.

What I've done:

  • An Indonesian directory added to Keyboards/LanguageKeyboards that includes a IndonesianKeyboardViewController.swift file
  • Indonesian language keyboard values and logic added to IDInterfaceVariables.swift in the above directory
  • Add Indonesian keyboard specific logic to KeyboardViewController.swift (mainly hiding the Conjugation and Plural command)

To do next:

I've run this in a simulator with placeholder database and it's loaded fine.

I will look into generating a SQLite database for Indonesian to get the keyboard functioning, focusing on autosuggestions, autocompletion, and translation, since I've decided to hide and disable Conjugation and Plural.

Looking forward for your feedback/reviews @andrewtavis 😊

Related issue

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CI unit test workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@catreedle
Copy link
Contributor Author

catreedle commented Oct 10, 2025

will look into the error soon 😅
(edit)
I think this is because I did not push the placeholder sqlite file.

@andrewtavis
Copy link
Member

I can also support with this, @catreedle :) Let's work on the Android keyboard as well in parallel, as it would be great to keep the apps synced. We can try to get this issue merged this weekend, and then you can continue here. Would you also want to open the issue for adding an Indonesian keyboard to Scribe-Android where you detail what's needed to add a new keyboard? :)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 11, 2025
@catreedle
Copy link
Contributor Author

sure, @andrewtavis :)

@andrewtavis andrewtavis self-requested a review October 20, 2025 21:14
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: This is some amazing work to bring add in a new language, @catreedle! Really thorough work!

note: I did some minor changes to get the UI working a bit better. Specifically, it'd be good if you check my commits and see where I'm doing edits to add spacing around the a and l keys so that there's space to the left of the a and right of the l to make sure that the space between keys is consistent 😊

note: Let's avoid edits to localization files for now. We need to bring over the new version of Scribe-i18n soon, which hopefully we can do later this weekend.

Feel free to work on this or the Android app implementation going forward! 🎉

@andrewtavis andrewtavis merged commit a38de63 into scribe-org:main Oct 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted as a part of Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants