-
Couldn't load subscription status.
- Fork 99
New Indonesian Keyboard #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the pull request! ❤️The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
will look into the error soon 😅 |
|
I can also support with this, @catreedle :) Let's work on the Android keyboard as well in parallel, as it would be great to keep the apps synced. We can try to get this issue merged this weekend, and then you can continue here. Would you also want to open the issue for adding an Indonesian keyboard to Scribe-Android where you detail what's needed to add a new keyboard? :) |
|
sure, @andrewtavis :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: This is some amazing work to bring add in a new language, @catreedle! Really thorough work!
note: I did some minor changes to get the UI working a bit better. Specifically, it'd be good if you check my commits and see where I'm doing edits to add spacing around the a and l keys so that there's space to the left of the a and right of the l to make sure that the space between keys is consistent 😊
note: Let's avoid edits to localization files for now. We need to bring over the new version of Scribe-i18n soon, which hopefully we can do later this weekend.
Feel free to work on this or the Android app implementation going forward! 🎉
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
This PR is for adding a new keyboard for the Indonesian language.
What I've done:
To do next:
I've run this in a simulator with placeholder database and it's loaded fine.
I will look into generating a SQLite database for Indonesian to get the keyboard functioning, focusing on autosuggestions, autocompletion, and translation, since I've decided to hide and disable Conjugation and Plural.
Looking forward for your feedback/reviews @andrewtavis 😊
Related issue