Open
Conversation
Member
Member
|
Hm I was thinking, maybe we'd save ourselves a lot of layouting work if we just had like a main menu thing where you could switch back and forth. Initially I actually had something like that, there was a tab pane with a create and join tab, but i decided to remove it ... maybe that was dumb. |
Contributor
Author
|
I pushed a fix for all of your points while retaining the current layout 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Closes #354, Closes #399
Key items implemented by this PR:
EditableLobbySettingsstruct to consolidate params passed toLobby.CreateLobbyto improve readability and make the number of params a bit more manageable.