Skip to content

feat: custom words per turn#405

Open
DeepSpace2 wants to merge 4 commits intoscribble-rs:masterfrom
DeepSpace2:custom-words-per-turn
Open

feat: custom words per turn#405
DeepSpace2 wants to merge 4 commits intoscribble-rs:masterfrom
DeepSpace2:custom-words-per-turn

Conversation

@DeepSpace2
Copy link
Contributor

@DeepSpace2 DeepSpace2 commented Feb 24, 2026

Closes #354, Closes #399

Key items implemented by this PR:

  • Implement configurable "words per turn" lobby settings. It has no max value and the minimum value is 1 for hard-core mode 😃
  • Implement "advanced settings" on main page for decluttering on mobile
  • Modernize lobby list item in existing lobbies list
  • Using existing EditableLobbySettings struct to consolidate params passed to Lobby.CreateLobby to improve readability and make the number of params a bit more manageable.

@DeepSpace2 DeepSpace2 marked this pull request as ready for review February 27, 2026 22:59
@Bios-Marcel
Copy link
Member

I think the textarea should push this:

image

Besides, the inputs still seem to have a different height and hence also different gaps between the components.

There also seems to be an unnecessary gap below the advanced section / the textarea, which is apparent when scrollable.

image image

The lobby list should have some kind of min-height, given the create element is scrollable too. As is, the list is inaccessible in certain display sizes:

image

On a wide setup the buttons vanish:

image

As for the changes in the lobby list, I think the color red isn't the nicest choice. Red means error or attention. So far the page only uses this for the system messages. Starting a game is something positive, so if we color the button, I think green would be nice :)

The hover effect seems to indicate clickability of the container, which is not the case. I think if you want that effect, it should be on the button?

It also doesn't seem to round the drop shadow correctly:

image

I've also noticed, you applied a max-height: 1000px to the advanced section. Is max-height: fit-content what we actually want? I feel like 99% of the time hardcoding heights / widths isn't a good idea.

@Bios-Marcel
Copy link
Member

Hm I was thinking, maybe we'd save ourselves a lot of layouting work if we just had like a main menu thing where you could switch back and forth.

Initially I actually had something like that, there was a tab pane with a create and join tab, but i decided to remove it ... maybe that was dumb.

@DeepSpace2
Copy link
Contributor Author

I pushed a fix for all of your points while retaining the current layout 😄
Indeed, it might be the time to look at a new design but I felt it was out of scope for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Options to customize the number of words to choose from Increase max amount of words to chose from

2 participants