fix: Router now throws 404 error rather than resolving allIndex in un…

…wanted situations
scrawler-labs · Oct 31, 2020 · ea9cdd9 · ea9cdd9
1 parent d85c701
commit ea9cdd9
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/RouterEngine.php b/src/RouterEngine.php
@@ -54,6 +54,7 @@ class RouterEngine
      */
     private $dirMode = false;
 
+
     /**
      * Store Dirctory during dir Mode
      */
@@ -187,7 +188,12 @@ private function setArguments()
         $classMethod = new \ReflectionMethod($controller, $this->method);
         if (count($arguments) < count($classMethod->getParameters())) {
             $this->error('Not enough arguments given to the method');
-        } else {
+        } 
+        // finally fix the long awaited allIndex bug !
+        elseif (count($arguments) > count($classMethod->getParameters())) {
+            $this->error('Not able to resolve any method for'.$this->controller.'controller');
+        }            
+        else {
             $this->request->attributes->set('_arguments', implode(",", $arguments));
         }
     }