feat: [UEPR-252] add manual save of thumnails #9638
Merged
+285
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KManolov3
requested review from
Copilot,
MiroslavDionisiev and
cwillisf
and removed request for
Copilot and
MiroslavDionisiev
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a manual thumbnail-saving flow by adding a feature flag, an informational modal on first use, and routing the thumbnail update through a custom handler.
- Add
MANUALLY_SAVE_THUMBNAILSenv var in Webpack and pass it through to the client - Create a tooltip and
UpdateThumbnailInfoModalto explain manual saves on first use - Update
PreviewandPreviewPresentationto use ahandleManualThumbnailUpdatepath and pass the new flag
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.config.js | Inject MANUALLY_SAVE_THUMBNAILS default into client env |
| src/views/preview/update-thumbnail-info-modal.scss | Styles for the first-use info modal |
| src/views/preview/update-thumbnail-info-modal.jsx | New modal component explaining manual thumbnail saves |
| src/views/preview/project-view.scss | Tooltip styling and driver.js overrides for manual-save hint |
| src/views/preview/project-view.jsx | Wire up handleManualThumbnailUpdate, tooltip, modal, and flag |
| src/views/preview/presentation.jsx | Pass manuallySaveThumbnails (and userOwnsProject) to GUI |
| src/views/preview/l10n.json | Add localized strings for tooltip and info modal |
Comments suppressed due to low confidence (1)
src/views/preview/project-view.jsx:852
- The new
handleManualThumbnailUpdateflow, including first-time tooltip and modal logic, doesn’t have any unit or integration tests. Adding tests for both the initial modal display and subsequent updates will help catch regressions.
handleManualThumbnailUpdate (id, blob) {
cwillisf
approved these changes
Jul 17, 2025
| @@ -414,6 +415,8 @@ const PreviewPresentation = ({ | |||
| onUpdateProjectId={onUpdateProjectId} | |||
| onUpdateProjectThumbnail={onUpdateProjectThumbnail} | |||
| shouldStopProject={shouldStopProject} | |||
| manuallySaveThumbnails={manuallySaveThumbnails} | |||
| userOwnsProject={userOwnsProject} | |||
There was a problem hiding this comment.
Is this flag actually used? I don't see it mentioned anywhere else in this PR...
There was a problem hiding this comment.
It's used in the editor to make sure we only show the update thumbnail button if the project is created by us:
scratchfoundation/scratch-editor#264
Co-authored-by: Christopher Willis-Ford <[email protected]>
MiroslavDionisiev
approved these changes
Jul 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-252
Proposed Changes
Update logic, so that thumbnails are now updated manually
Reason for Changes
This will hopefully allow us to reduce monthly costs connected with thumbnail updates