[UEPR-331] Implement face sensing callouts #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwillisf
requested changes
Sep 29, 2025
There was a problem hiding this comment.
Looks good other than waiting for scratchfoundation/scratch-webpack-configuration#105
One idea to consider: it might make sense to make the callouts appear as long as now is less than some end date. That way, if we release this in the apps, the callouts will appear for a while and then go away even if the user doesn't update their copy of the app. On the other hand, maybe we want that date to be different on the web vs. in the apps. Hmm...
packages/scratch-gui/package.json
Outdated
| "redux-mock-store": "1.5.5", | ||
| "rimraf": "2.7.1", | ||
| "scratch-semantic-release-config": "3.0.0", | ||
| "scratch-webpack-configuration": "3.0.0", |
There was a problem hiding this comment.
Probably already on your todo list: this will need a version bump, probably to 3.1.0, once scratchfoundation/scratch-webpack-configuration#105 gets merged
adzhindzhi
changed the title
KManolov3
commented
Sep 30, 2025
packages/scratch-gui/src/components/library-item/library-item.raw.css
Outdated
Show resolved
Hide resolved
packages/scratch-gui/src/components/extension-button/extension-button.jsx
Outdated
Show resolved
Hide resolved
KManolov3
commented
Oct 1, 2025
KManolov3
commented
Oct 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-331
Proposed Changes
Add feature callouts for new face sensing feature
Reason for Changes
To introduce the face sensing feature to users.